You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/02/27 03:58:40 UTC
Review Request 31512: Added ability to inject the RateLimiter for
slave removals.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31512/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
To test the slave removal rate limiting, we needed to ensure that no slave removals occur before the rate limiting ticket is ready. This requires controlling when the Future from `aquire` is satisfied, so a MockRateLimiter needs to get injected into the Master.
Diffs
-----
src/local/local.cpp 8189edb36ea56cf08d01c458604aa9b9c7bbe2bf
src/master/main.cpp f2020196e92f819f2f2e6a7805822a2bda2e38d2
src/master/master.hpp 8c44d6ed57ad1b94a17bef8142a5e6a15889a810
src/master/master.cpp 76e217d16c03e587ea4c0afca94c58b2212f0f93
src/tests/cluster.hpp da242d967c68abcb7ccad9895e69c235d12b048e
Diff: https://reviews.apache.org/r/31512/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 31512: Added ability to inject the RateLimiter for
slave removals.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31512/#review74561
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 27, 2015, 2:58 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31512/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 2:58 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To test the slave removal rate limiting, we needed to ensure that no slave removals occur before the rate limiting ticket is ready. This requires controlling when the Future from `aquire` is satisfied, so a MockRateLimiter needs to get injected into the Master.
>
>
> Diffs
> -----
>
> src/local/local.cpp 8189edb36ea56cf08d01c458604aa9b9c7bbe2bf
> src/master/main.cpp f2020196e92f819f2f2e6a7805822a2bda2e38d2
> src/master/master.hpp 8c44d6ed57ad1b94a17bef8142a5e6a15889a810
> src/master/master.cpp 76e217d16c03e587ea4c0afca94c58b2212f0f93
> src/tests/cluster.hpp da242d967c68abcb7ccad9895e69c235d12b048e
>
> Diff: https://reviews.apache.org/r/31512/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 31512: Added ability to inject the RateLimiter for
slave removals.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31512/#review74474
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Feb. 27, 2015, 3:58 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31512/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 3:58 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To test the slave removal rate limiting, we needed to ensure that no slave removals occur before the rate limiting ticket is ready. This requires controlling when the Future from `aquire` is satisfied, so a MockRateLimiter needs to get injected into the Master.
>
>
> Diffs
> -----
>
> src/local/local.cpp 8189edb36ea56cf08d01c458604aa9b9c7bbe2bf
> src/master/main.cpp f2020196e92f819f2f2e6a7805822a2bda2e38d2
> src/master/master.hpp 8c44d6ed57ad1b94a17bef8142a5e6a15889a810
> src/master/master.cpp 76e217d16c03e587ea4c0afca94c58b2212f0f93
> src/tests/cluster.hpp da242d967c68abcb7ccad9895e69c235d12b048e
>
> Diff: https://reviews.apache.org/r/31512/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>