You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by "shubham-j-sde (via GitHub)" <gi...@apache.org> on 2025/03/29 10:06:39 UTC
[PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
shubham-j-sde opened a new pull request, #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1
addresses [#34308](https://github.com/apache/beam/issues/34308#issuecomment-2759456158)
- [x] Remove the links related to Polber
- [x] Switch Beam to 2.63.0 or the latest
- [ ] Check whether Java 21 works
- [ ] Create the detailed steps to run the example locally and using Dataflow
- [ ] Create the example outputs as the reference for users to check
- [ ] Depend Bot to update Beam when it is released
- [ ] Create a simple test workflow to validate the pipeline works
Have also updated autovalue to next stable version.
Jar package is generated with both Java 11 and 21. working on testing jar file with yaml pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
Posted by "shubham-j-sde (via GitHub)" <gi...@apache.org>.
shubham-j-sde commented on code in PR #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1#discussion_r2029873715
##########
tutorial.md:
##########
@@ -0,0 +1,356 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
Review Comment:
I believe if someone is new to Beam YAML, they will also require to follow [Yaml overview](https://beam.apache.org/documentation/sdks/yaml/) and [providers](https://beam.apache.org/documentation/sdks/yaml-providers/) docs along with this Readme to really understand whats happening. (I needed them 😅)
I can add a few lines in Readme for the same, along with example links for Renaming and Error Handling parameters, if that sounds ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
Posted by "shubham-j-sde (via GitHub)" <gi...@apache.org>.
shubham-j-sde commented on PR #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1#issuecomment-2764603590
Hey @liferoad, so I have added workflow files to validate pipeline, have also tested them on my forked repo.
I'll add `tutorial.md` explaining detailed steps for local setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1#issuecomment-2780719664
Some minor comments. Overall, looks good. Thanks!
We probably need to add steps for Dataflow later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1#issuecomment-2763335997
Is this ready for review ? Looks like you want to do more validations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
Posted by "shubham-j-sde (via GitHub)" <gi...@apache.org>.
shubham-j-sde commented on code in PR #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1#discussion_r2029873715
##########
tutorial.md:
##########
@@ -0,0 +1,356 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
Review Comment:
I believe if someone is new to Beam YAML, they will also require to follow [Yaml overview](https://beam.apache.org/documentation/sdks/yaml/) and [providers](https://beam.apache.org/documentation/sdks/yaml-providers/) docs along with this Readme to really understand whats happening.
I can add a few lines in Readme for the same, along with example links for Renaming and Error Handling parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
Posted by "shubham-j-sde (via GitHub)" <gi...@apache.org>.
shubham-j-sde commented on code in PR #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1#discussion_r2029878865
##########
tutorial.md:
##########
@@ -0,0 +1,356 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
Review Comment:
have done said changes in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
Posted by "shubham-j-sde (via GitHub)" <gi...@apache.org>.
shubham-j-sde commented on PR #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1#issuecomment-2763560044
I was able to test setup locally for both Java 11 and 21, works on both.
needs a gcloud billing account to create dataflows, which I don't have.
I can add detailed steps on running example locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
Posted by "shubham-j-sde (via GitHub)" <gi...@apache.org>.
shubham-j-sde commented on PR #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1#issuecomment-2780672485
Hey @liferoad,
can you please check the changes now.
I have given brief examples for `error_handling` and `renaming`. I'll raise another PR to add some more detailed examples if u think its required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
Posted by "shubham-j-sde (via GitHub)" <gi...@apache.org>.
shubham-j-sde commented on PR #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1#issuecomment-2764631911
can also add license header check to the workflow, currently no files have them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
Posted by "shubham-j-sde (via GitHub)" <gi...@apache.org>.
shubham-j-sde commented on code in PR #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1#discussion_r2029873715
##########
tutorial.md:
##########
@@ -0,0 +1,356 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
Review Comment:
I believe if someone is new to Beam YAML, they will also require to follow [Yaml overview](https://beam.apache.org/documentation/sdks/yaml/) and [providers](https://beam.apache.org/documentation/sdks/yaml-providers/) docs along with this Readme to really understand whats happening. (I needed them 😅)
I can add a few lines in Readme for the same, along with example links for Renaming and Error Handling parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
Posted by "shubham-j-sde (via GitHub)" <gi...@apache.org>.
shubham-j-sde commented on PR #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1#issuecomment-2763340815
no, not ready yet. I'll tag you soon for first review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
Posted by "shubham-j-sde (via GitHub)" <gi...@apache.org>.
shubham-j-sde commented on PR #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1#issuecomment-2763565333
<img width="1440" alt="Screenshot 2025-03-29 at 9 12 01 PM" src="https://github.com/user-attachments/assets/04be2e62-1700-4a30-91e1-e6830f53d3e6" />
<img width="1440" alt="Screenshot 2025-03-29 at 7 14 31 PM" src="https://github.com/user-attachments/assets/3d0027f2-4794-42bf-a90e-ecddcf149bac" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1#discussion_r2029869499
##########
.github/dependabot.yml:
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:
+ - package-ecosystem: "maven"
+ directory: "/" # Location of package manifests
+ schedule:
+ interval: "weekly"
+ ignore:
+ - dependency-name: "*"
+ update-types: [ "version-update:semver-patch" ]
+# reviewers:
Review Comment:
you can remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java starter pack readme, version, and examples [beam-starter-java-provider]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #1:
URL: https://github.com/apache/beam-starter-java-provider/pull/1#discussion_r2029869585
##########
tutorial.md:
##########
@@ -0,0 +1,356 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
Review Comment:
This has many overlaps with README.md. Can we just use README.md?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org