You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by bryancall <gi...@git.apache.org> on 2016/08/24 03:07:36 UTC
[GitHub] trafficserver pull request #910: TS-1509: Remove TS_PARSE_OK constant
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/910
TS-1509: Remove TS_PARSE_OK constant
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-1509
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/910.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #910
----
commit ac412957fb6069f96c76c2b39ea489030476f15e
Author: Bryan Call <bc...@apache.org>
Date: 2016-08-24T03:06:08Z
TS-1509: Remove TS_PARSE_OK constant
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #910: TS-1509: Remove TS_PARSE_OK constant
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/910
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #910: TS-1509: Remove TS_PARSE_OK constant
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/910
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/601/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #910: TS-1509: Remove TS_PARSE_OK constant
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/910
@jpeach I updated `MIMEParseResult` to have the same values as TSParseResult. I will file a bug for getting rid of `MIMEParseResult::PARSE_OK` and now that the value is only used internally it won't be an incompatible change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #910: TS-1509: Remove TS_PARSE_OK constant
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/910
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/597/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #910: TS-1509: Remove TS_PARSE_OK constant
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/910
\U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #910: TS-1509: Remove TS_PARSE_OK constant
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/910#discussion_r75990191
--- Diff: lib/ts/apidefs.h.in ---
@@ -124,8 +124,7 @@ typedef struct {
typedef enum {
TS_PARSE_ERROR = -1,
TS_PARSE_DONE = 0,
- TS_PARSE_OK = 1,
- TS_PARSE_CONT = 2,
+ TS_PARSE_CONT = 1,
--- End diff --
I think it would be kinder to plugin authors to leave ``TS_PARSE_CONT = 2`` and ``#define TS_PARSE_OK TS_PARSE_DONE``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #910: TS-1509: Remove TS_PARSE_OK constant
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/910#discussion_r76106620
--- Diff: lib/ts/apidefs.h.in ---
@@ -124,8 +124,7 @@ typedef struct {
typedef enum {
TS_PARSE_ERROR = -1,
TS_PARSE_DONE = 0,
- TS_PARSE_OK = 1,
- TS_PARSE_CONT = 2,
+ TS_PARSE_CONT = 1,
--- End diff --
I can live with that too, just trying to make is easier for 3rd party plugins to make the transition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #910: TS-1509: Remove TS_PARSE_OK constant
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/910
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/493/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #910: TS-1509: Remove TS_PARSE_OK constant
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/910
This also needs to remove ``MIMEParseResult::PARSE_OK`` since that is where these resutn codes originate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #910: TS-1509: Remove TS_PARSE_OK constant
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/910#discussion_r76105541
--- Diff: lib/ts/apidefs.h.in ---
@@ -124,8 +124,7 @@ typedef struct {
typedef enum {
TS_PARSE_ERROR = -1,
TS_PARSE_DONE = 0,
- TS_PARSE_OK = 1,
- TS_PARSE_CONT = 2,
+ TS_PARSE_CONT = 1,
--- End diff --
I disagree. I think we should kill it with fire. Why pollute the namespace with a useless name?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #910: TS-1509: Remove TS_PARSE_OK constant
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/910
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/497/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---