[GitHub] [bookkeeper] eolivelli commented on pull request #2404: BP-41 BookieId - client side implementation

[GitBox <gi...@apache.org>]

eolivelli commented on pull request #2404:
URL: https://github.com/apache/bookkeeper/pull/2404#issuecomment-687659723


   @Ghatage very good points!
   
   Regarding useShortHostName=true,  we have a few minimal tests (that broke during my first impl). 
   With this new behaviour that flag should work because it is about the advertised address of the bookie (that is currently the same as the bookieId, in a follow up patch you will see bookieId configurable)
   If you change that flag in an existing bookie and use  the automatic bookieId generation then clients would not be able to read old ledgers because they refer to unadvertised bookieIds.
   With BP41 you will be able to change the advertised address and in the future even the protocol advertised by the bookie and leave existing ledger metadata valid.
   
   Regarding 2)....that function and RackAware stuff will still use BookieSocketAddress to map a bookie to a current rack. All tests are passing. I don't have much experience here but im my opinion there won't be any need to change the placement policies. 
   You will be able to implement more sophisticated policies and of you use some smart bookieId you won't need to pass from DNS or other script to map a bookie to the region/rack.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org