[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #16148: Fixing build for gluon estimator test, including libtvm in pack libs

[GitBox <gi...@apache.org>]

anirudh2290 commented on a change in pull request #16148: Fixing build for gluon estimator test, including libtvm in pack libs
URL: https://github.com/apache/incubator-mxnet/pull/16148#discussion_r323549042
 
 

 ##########
 File path: docs/mxdoc.py
 ##########
 @@ -468,7 +468,13 @@ def copy_artifacts(app):
 def setup(app):
     # If MXNET_DOCS_BUILD_MXNET is set something different than 1
     # Skip the build step
-    if os.getenv('MXNET_DOCS_BUILD_MXNET') == '1'or _MXNET_DOCS_BUILD_MXNET:
+    env_build_mxnet = os.getenv('MXNET_DOCS_BUILD_MXNET', default=None)
+    should_build_mxnet = _MXNET_DOCS_BUILD_MXNET
+    if env_build_mxnet is not None:
+        print("env MXNET_DOCS_BUILD_MXNET is set to " + str(env_build_mxnet))
+        should_build_mxnet = (env_build_mxnet == '1')
+
+    if should_build_mxnet:
 
 Review comment:
   is this needed?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services