You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Liangyu Zhao via Review Board <no...@reviews.apache.org> on 2018/08/02 21:31:23 UTC
Review Request 68175: Windows: Change strings in Windows os code to
`wstring`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68175/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.
Repository: mesos
Description
-------
Functions in `stout/internal/windows` and `stout/os/windows` now use
`std::wstring` instead of `std::string`. Narrow string is still
supported, but will converted to wide string for process. The return
values for functions are unchanged.
Diffs
-----
3rdparty/stout/include/stout/internal/windows/attributes.hpp 673b744588fee32aa4c462199be0675c392636fb
3rdparty/stout/include/stout/internal/windows/longpath.hpp 499eef30a3d16ac1f6c2e3334ef773e91e987a45
3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 280956ff9cfb0efcc5b0aa7ef35473122d9dd8c0
3rdparty/stout/include/stout/internal/windows/symlink.hpp def5515656a5a454655d6a484c7e52ea12be8a55
3rdparty/stout/include/stout/os/constants.hpp f81dbb3b7dcd929475324047f32cbabd873bea81
3rdparty/stout/include/stout/os/windows/chdir.hpp 523c7f75bd120b00f815c4c4aac946fdb5dbaaa5
3rdparty/stout/include/stout/os/windows/copyfile.hpp 34723bce9a151582de481d63a865509d4d29c02c
3rdparty/stout/include/stout/os/windows/exists.hpp 50bb92a1e4100a89a346d6bafc6d4133e6e40589
3rdparty/stout/include/stout/os/windows/getcwd.hpp daf131ac1da705724e85cd236c68685422d2f3c8
3rdparty/stout/include/stout/os/windows/getenv.hpp 034510cff3701f1063c4fa7ff5c0acb63b421717
3rdparty/stout/include/stout/os/windows/ls.hpp 68d5a6037c4c73d6233829259e4fceb4db613a0c
3rdparty/stout/include/stout/os/windows/mkdir.hpp 2aef22a47a80eddc9db0cd4e4ae3daf77c52c05b
3rdparty/stout/include/stout/os/windows/mkdtemp.hpp f742f0838cdc5132286f55775ca042ce8057c166
3rdparty/stout/include/stout/os/windows/mktemp.hpp b4f5279a58274f02b260bdb3b94c284547842a0f
3rdparty/stout/include/stout/os/windows/open.hpp b2f033c19027144083dc02cf3d4081b1fb26b501
3rdparty/stout/include/stout/os/windows/realpath.hpp 6bfaaf63f849129793b5b3e2d501623ec83e9d4f
3rdparty/stout/include/stout/os/windows/rename.hpp 523912ac3bf315f70f542e8eab7d2d02249909b4
3rdparty/stout/include/stout/os/windows/rm.hpp 2cacb28ec534e0f3e213d04ddf56168bc2061901
3rdparty/stout/include/stout/os/windows/rmdir.hpp 00821cdb62a02824e26ddb125eca66694165ce1f
3rdparty/stout/include/stout/os/windows/shell.hpp b9e06d667159d2fb5e266ce7f7e633deb1237a78
3rdparty/stout/include/stout/os/windows/stat.hpp 62256094b9a58779e28dd78f1281a7d8bd7955d0
3rdparty/stout/include/stout/os/windows/su.hpp ac3a8968f7b9fe6889e13aa47595ae45a094c891
3rdparty/stout/include/stout/os/windows/temp.hpp 4e8543ee6b67f0c2b50a858826e19eed211452bc
3rdparty/stout/include/stout/windows/net.hpp 74398637fe830af0655b1358d4ea52d259a97e9e
3rdparty/stout/include/stout/windows/os.hpp 4f26806e4e027c090c6e7ce07b1bb8d2dabfb531
Diff: https://reviews.apache.org/r/68175/diff/1/
Testing
-------
Thanks,
Liangyu Zhao
Re: Review Request 68175: Windows: Change strings in Windows os code
to `wstring`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68175/#review206921
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68174', '68175']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2103/mesos-review-68175
Relevant logs:
- [stout-tests.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2103/mesos-review-68175/logs/stout-tests.log):
```
[ RUN ] SocketTests.InitSocket
[ OK ] SocketTests.InitSocket (1 ms)
[ RUN ] SocketTests.IntFD
[ OK ] SocketTests.IntFD (2 ms)
[----------] 2 tests from SocketTests (3 ms total)
[----------] 2 tests from StrerrorTest
[ RUN ] StrerrorTest.ValidErrno
[ OK ] StrerrorTest.ValidErrno (0 ms)
[ RUN ] StrerrorTest.InvalidErrno
[ OK ] StrerrorTest.InvalidErrno (0 ms)
[----------] 2 tests from StrerrorTest (0 ms total)
[----------] 2 tests from OsSendfileTest
[ RUN ] OsSendfileTest.Sendfile
[ OK ] OsSendfileTest.Sendfile (1510 ms)
[ RUN ] OsSendfileTest.SendfileAsync
[ OK ] OsSendfileTest.SendfileAsync (13 ms)
[----------] 2 tests from OsSendfileTest (1523 ms total)
[----------] Global test environment tear-down
[==========] 333 tests from 52 test cases ran. (5225 ms total)
[ PASSED ] 332 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] OsTest.SYMLINK_Size
1 FAILED TEST
YOU HAVE 1 DISABLED TEST
```
- Mesos Reviewbot Windows
On Aug. 2, 2018, 9:31 p.m., Liangyu Zhao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68175/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2018, 9:31 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Functions in `stout/internal/windows` and `stout/os/windows` now use
> `std::wstring` instead of `std::string`. Narrow string is still
> supported, but will converted to wide string for process. The return
> values for functions are unchanged.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/internal/windows/attributes.hpp 673b744588fee32aa4c462199be0675c392636fb
> 3rdparty/stout/include/stout/internal/windows/longpath.hpp 499eef30a3d16ac1f6c2e3334ef773e91e987a45
> 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 280956ff9cfb0efcc5b0aa7ef35473122d9dd8c0
> 3rdparty/stout/include/stout/internal/windows/symlink.hpp def5515656a5a454655d6a484c7e52ea12be8a55
> 3rdparty/stout/include/stout/os/constants.hpp f81dbb3b7dcd929475324047f32cbabd873bea81
> 3rdparty/stout/include/stout/os/windows/chdir.hpp 523c7f75bd120b00f815c4c4aac946fdb5dbaaa5
> 3rdparty/stout/include/stout/os/windows/copyfile.hpp 34723bce9a151582de481d63a865509d4d29c02c
> 3rdparty/stout/include/stout/os/windows/exists.hpp 50bb92a1e4100a89a346d6bafc6d4133e6e40589
> 3rdparty/stout/include/stout/os/windows/getcwd.hpp daf131ac1da705724e85cd236c68685422d2f3c8
> 3rdparty/stout/include/stout/os/windows/getenv.hpp 034510cff3701f1063c4fa7ff5c0acb63b421717
> 3rdparty/stout/include/stout/os/windows/ls.hpp 68d5a6037c4c73d6233829259e4fceb4db613a0c
> 3rdparty/stout/include/stout/os/windows/mkdir.hpp 2aef22a47a80eddc9db0cd4e4ae3daf77c52c05b
> 3rdparty/stout/include/stout/os/windows/mkdtemp.hpp f742f0838cdc5132286f55775ca042ce8057c166
> 3rdparty/stout/include/stout/os/windows/mktemp.hpp b4f5279a58274f02b260bdb3b94c284547842a0f
> 3rdparty/stout/include/stout/os/windows/open.hpp b2f033c19027144083dc02cf3d4081b1fb26b501
> 3rdparty/stout/include/stout/os/windows/realpath.hpp 6bfaaf63f849129793b5b3e2d501623ec83e9d4f
> 3rdparty/stout/include/stout/os/windows/rename.hpp 523912ac3bf315f70f542e8eab7d2d02249909b4
> 3rdparty/stout/include/stout/os/windows/rm.hpp 2cacb28ec534e0f3e213d04ddf56168bc2061901
> 3rdparty/stout/include/stout/os/windows/rmdir.hpp 00821cdb62a02824e26ddb125eca66694165ce1f
> 3rdparty/stout/include/stout/os/windows/shell.hpp b9e06d667159d2fb5e266ce7f7e633deb1237a78
> 3rdparty/stout/include/stout/os/windows/stat.hpp 62256094b9a58779e28dd78f1281a7d8bd7955d0
> 3rdparty/stout/include/stout/os/windows/su.hpp ac3a8968f7b9fe6889e13aa47595ae45a094c891
> 3rdparty/stout/include/stout/os/windows/temp.hpp 4e8543ee6b67f0c2b50a858826e19eed211452bc
> 3rdparty/stout/include/stout/windows/net.hpp 74398637fe830af0655b1358d4ea52d259a97e9e
> 3rdparty/stout/include/stout/windows/os.hpp 4f26806e4e027c090c6e7ce07b1bb8d2dabfb531
>
>
> Diff: https://reviews.apache.org/r/68175/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Liangyu Zhao
>
>
Re: Review Request 68175: Windows: Change strings in Windows os code
to `wstring`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68175/#review207737
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68174, 68175]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 22, 2018, 12:38 a.m., Liangyu Zhao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68175/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2018, 12:38 a.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Functions in `stout/internal/windows` and `stout/os/windows` now use
> `std::wstring` instead of `std::string`. Narrow string is still
> supported, but will converted to wide string for process. The return
> values for functions are unchanged.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/internal/windows/attributes.hpp 673b744588fee32aa4c462199be0675c392636fb
> 3rdparty/stout/include/stout/internal/windows/longpath.hpp 499eef30a3d16ac1f6c2e3334ef773e91e987a45
> 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 280956ff9cfb0efcc5b0aa7ef35473122d9dd8c0
> 3rdparty/stout/include/stout/internal/windows/symlink.hpp def5515656a5a454655d6a484c7e52ea12be8a55
> 3rdparty/stout/include/stout/os/constants.hpp f81dbb3b7dcd929475324047f32cbabd873bea81
> 3rdparty/stout/include/stout/os/windows/chdir.hpp 523c7f75bd120b00f815c4c4aac946fdb5dbaaa5
> 3rdparty/stout/include/stout/os/windows/copyfile.hpp 34723bce9a151582de481d63a865509d4d29c02c
> 3rdparty/stout/include/stout/os/windows/exists.hpp 50bb92a1e4100a89a346d6bafc6d4133e6e40589
> 3rdparty/stout/include/stout/os/windows/getcwd.hpp daf131ac1da705724e85cd236c68685422d2f3c8
> 3rdparty/stout/include/stout/os/windows/getenv.hpp 034510cff3701f1063c4fa7ff5c0acb63b421717
> 3rdparty/stout/include/stout/os/windows/ls.hpp 68d5a6037c4c73d6233829259e4fceb4db613a0c
> 3rdparty/stout/include/stout/os/windows/mkdir.hpp 2aef22a47a80eddc9db0cd4e4ae3daf77c52c05b
> 3rdparty/stout/include/stout/os/windows/mkdtemp.hpp f742f0838cdc5132286f55775ca042ce8057c166
> 3rdparty/stout/include/stout/os/windows/mktemp.hpp b4f5279a58274f02b260bdb3b94c284547842a0f
> 3rdparty/stout/include/stout/os/windows/open.hpp b2f033c19027144083dc02cf3d4081b1fb26b501
> 3rdparty/stout/include/stout/os/windows/realpath.hpp 6bfaaf63f849129793b5b3e2d501623ec83e9d4f
> 3rdparty/stout/include/stout/os/windows/rename.hpp 523912ac3bf315f70f542e8eab7d2d02249909b4
> 3rdparty/stout/include/stout/os/windows/rm.hpp 2cacb28ec534e0f3e213d04ddf56168bc2061901
> 3rdparty/stout/include/stout/os/windows/rmdir.hpp 00821cdb62a02824e26ddb125eca66694165ce1f
> 3rdparty/stout/include/stout/os/windows/shell.hpp b9e06d667159d2fb5e266ce7f7e633deb1237a78
> 3rdparty/stout/include/stout/os/windows/stat.hpp 62256094b9a58779e28dd78f1281a7d8bd7955d0
> 3rdparty/stout/include/stout/os/windows/su.hpp ac3a8968f7b9fe6889e13aa47595ae45a094c891
> 3rdparty/stout/include/stout/os/windows/temp.hpp 4e8543ee6b67f0c2b50a858826e19eed211452bc
> 3rdparty/stout/include/stout/windows/net.hpp 74398637fe830af0655b1358d4ea52d259a97e9e
> 3rdparty/stout/include/stout/windows/os.hpp 4f26806e4e027c090c6e7ce07b1bb8d2dabfb531
>
>
> Diff: https://reviews.apache.org/r/68175/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Liangyu Zhao
>
>
Re: Review Request 68175: Windows: Change strings in Windows os code
to `wstring`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68175/#review207723
-----------------------------------------------------------
PASS: Mesos patch 68175 was successfully built and tested.
Reviews applied: `['68174', '68175']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2215/mesos-review-68175
- Mesos Reviewbot Windows
On Aug. 22, 2018, 12:38 a.m., Liangyu Zhao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68175/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2018, 12:38 a.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Functions in `stout/internal/windows` and `stout/os/windows` now use
> `std::wstring` instead of `std::string`. Narrow string is still
> supported, but will converted to wide string for process. The return
> values for functions are unchanged.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/internal/windows/attributes.hpp 673b744588fee32aa4c462199be0675c392636fb
> 3rdparty/stout/include/stout/internal/windows/longpath.hpp 499eef30a3d16ac1f6c2e3334ef773e91e987a45
> 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 280956ff9cfb0efcc5b0aa7ef35473122d9dd8c0
> 3rdparty/stout/include/stout/internal/windows/symlink.hpp def5515656a5a454655d6a484c7e52ea12be8a55
> 3rdparty/stout/include/stout/os/constants.hpp f81dbb3b7dcd929475324047f32cbabd873bea81
> 3rdparty/stout/include/stout/os/windows/chdir.hpp 523c7f75bd120b00f815c4c4aac946fdb5dbaaa5
> 3rdparty/stout/include/stout/os/windows/copyfile.hpp 34723bce9a151582de481d63a865509d4d29c02c
> 3rdparty/stout/include/stout/os/windows/exists.hpp 50bb92a1e4100a89a346d6bafc6d4133e6e40589
> 3rdparty/stout/include/stout/os/windows/getcwd.hpp daf131ac1da705724e85cd236c68685422d2f3c8
> 3rdparty/stout/include/stout/os/windows/getenv.hpp 034510cff3701f1063c4fa7ff5c0acb63b421717
> 3rdparty/stout/include/stout/os/windows/ls.hpp 68d5a6037c4c73d6233829259e4fceb4db613a0c
> 3rdparty/stout/include/stout/os/windows/mkdir.hpp 2aef22a47a80eddc9db0cd4e4ae3daf77c52c05b
> 3rdparty/stout/include/stout/os/windows/mkdtemp.hpp f742f0838cdc5132286f55775ca042ce8057c166
> 3rdparty/stout/include/stout/os/windows/mktemp.hpp b4f5279a58274f02b260bdb3b94c284547842a0f
> 3rdparty/stout/include/stout/os/windows/open.hpp b2f033c19027144083dc02cf3d4081b1fb26b501
> 3rdparty/stout/include/stout/os/windows/realpath.hpp 6bfaaf63f849129793b5b3e2d501623ec83e9d4f
> 3rdparty/stout/include/stout/os/windows/rename.hpp 523912ac3bf315f70f542e8eab7d2d02249909b4
> 3rdparty/stout/include/stout/os/windows/rm.hpp 2cacb28ec534e0f3e213d04ddf56168bc2061901
> 3rdparty/stout/include/stout/os/windows/rmdir.hpp 00821cdb62a02824e26ddb125eca66694165ce1f
> 3rdparty/stout/include/stout/os/windows/shell.hpp b9e06d667159d2fb5e266ce7f7e633deb1237a78
> 3rdparty/stout/include/stout/os/windows/stat.hpp 62256094b9a58779e28dd78f1281a7d8bd7955d0
> 3rdparty/stout/include/stout/os/windows/su.hpp ac3a8968f7b9fe6889e13aa47595ae45a094c891
> 3rdparty/stout/include/stout/os/windows/temp.hpp 4e8543ee6b67f0c2b50a858826e19eed211452bc
> 3rdparty/stout/include/stout/windows/net.hpp 74398637fe830af0655b1358d4ea52d259a97e9e
> 3rdparty/stout/include/stout/windows/os.hpp 4f26806e4e027c090c6e7ce07b1bb8d2dabfb531
>
>
> Diff: https://reviews.apache.org/r/68175/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Liangyu Zhao
>
>
Re: Review Request 68175: Windows: Change strings in Windows os code
to `wstring`.
Posted by Liangyu Zhao via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68175/
-----------------------------------------------------------
(Updated Aug. 22, 2018, 12:38 a.m.)
Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.
Repository: mesos
Description
-------
Functions in `stout/internal/windows` and `stout/os/windows` now use
`std::wstring` instead of `std::string`. Narrow string is still
supported, but will converted to wide string for process. The return
values for functions are unchanged.
Diffs (updated)
-----
3rdparty/stout/include/stout/internal/windows/attributes.hpp 673b744588fee32aa4c462199be0675c392636fb
3rdparty/stout/include/stout/internal/windows/longpath.hpp 499eef30a3d16ac1f6c2e3334ef773e91e987a45
3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 280956ff9cfb0efcc5b0aa7ef35473122d9dd8c0
3rdparty/stout/include/stout/internal/windows/symlink.hpp def5515656a5a454655d6a484c7e52ea12be8a55
3rdparty/stout/include/stout/os/constants.hpp f81dbb3b7dcd929475324047f32cbabd873bea81
3rdparty/stout/include/stout/os/windows/chdir.hpp 523c7f75bd120b00f815c4c4aac946fdb5dbaaa5
3rdparty/stout/include/stout/os/windows/copyfile.hpp 34723bce9a151582de481d63a865509d4d29c02c
3rdparty/stout/include/stout/os/windows/exists.hpp 50bb92a1e4100a89a346d6bafc6d4133e6e40589
3rdparty/stout/include/stout/os/windows/getcwd.hpp daf131ac1da705724e85cd236c68685422d2f3c8
3rdparty/stout/include/stout/os/windows/getenv.hpp 034510cff3701f1063c4fa7ff5c0acb63b421717
3rdparty/stout/include/stout/os/windows/ls.hpp 68d5a6037c4c73d6233829259e4fceb4db613a0c
3rdparty/stout/include/stout/os/windows/mkdir.hpp 2aef22a47a80eddc9db0cd4e4ae3daf77c52c05b
3rdparty/stout/include/stout/os/windows/mkdtemp.hpp f742f0838cdc5132286f55775ca042ce8057c166
3rdparty/stout/include/stout/os/windows/mktemp.hpp b4f5279a58274f02b260bdb3b94c284547842a0f
3rdparty/stout/include/stout/os/windows/open.hpp b2f033c19027144083dc02cf3d4081b1fb26b501
3rdparty/stout/include/stout/os/windows/realpath.hpp 6bfaaf63f849129793b5b3e2d501623ec83e9d4f
3rdparty/stout/include/stout/os/windows/rename.hpp 523912ac3bf315f70f542e8eab7d2d02249909b4
3rdparty/stout/include/stout/os/windows/rm.hpp 2cacb28ec534e0f3e213d04ddf56168bc2061901
3rdparty/stout/include/stout/os/windows/rmdir.hpp 00821cdb62a02824e26ddb125eca66694165ce1f
3rdparty/stout/include/stout/os/windows/shell.hpp b9e06d667159d2fb5e266ce7f7e633deb1237a78
3rdparty/stout/include/stout/os/windows/stat.hpp 62256094b9a58779e28dd78f1281a7d8bd7955d0
3rdparty/stout/include/stout/os/windows/su.hpp ac3a8968f7b9fe6889e13aa47595ae45a094c891
3rdparty/stout/include/stout/os/windows/temp.hpp 4e8543ee6b67f0c2b50a858826e19eed211452bc
3rdparty/stout/include/stout/windows/net.hpp 74398637fe830af0655b1358d4ea52d259a97e9e
3rdparty/stout/include/stout/windows/os.hpp 4f26806e4e027c090c6e7ce07b1bb8d2dabfb531
Diff: https://reviews.apache.org/r/68175/diff/3/
Changes: https://reviews.apache.org/r/68175/diff/2-3/
Testing
-------
Thanks,
Liangyu Zhao
Re: Review Request 68175: Windows: Change strings in Windows os code
to `wstring`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68175/#review206963
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68174, 68175]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 2, 2018, 9:31 p.m., Liangyu Zhao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68175/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2018, 9:31 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Functions in `stout/internal/windows` and `stout/os/windows` now use
> `std::wstring` instead of `std::string`. Narrow string is still
> supported, but will converted to wide string for process. The return
> values for functions are unchanged.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/internal/windows/attributes.hpp 673b744588fee32aa4c462199be0675c392636fb
> 3rdparty/stout/include/stout/internal/windows/longpath.hpp 499eef30a3d16ac1f6c2e3334ef773e91e987a45
> 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 280956ff9cfb0efcc5b0aa7ef35473122d9dd8c0
> 3rdparty/stout/include/stout/internal/windows/symlink.hpp def5515656a5a454655d6a484c7e52ea12be8a55
> 3rdparty/stout/include/stout/os/constants.hpp f81dbb3b7dcd929475324047f32cbabd873bea81
> 3rdparty/stout/include/stout/os/windows/chdir.hpp 523c7f75bd120b00f815c4c4aac946fdb5dbaaa5
> 3rdparty/stout/include/stout/os/windows/copyfile.hpp 34723bce9a151582de481d63a865509d4d29c02c
> 3rdparty/stout/include/stout/os/windows/exists.hpp 50bb92a1e4100a89a346d6bafc6d4133e6e40589
> 3rdparty/stout/include/stout/os/windows/getcwd.hpp daf131ac1da705724e85cd236c68685422d2f3c8
> 3rdparty/stout/include/stout/os/windows/getenv.hpp 034510cff3701f1063c4fa7ff5c0acb63b421717
> 3rdparty/stout/include/stout/os/windows/ls.hpp 68d5a6037c4c73d6233829259e4fceb4db613a0c
> 3rdparty/stout/include/stout/os/windows/mkdir.hpp 2aef22a47a80eddc9db0cd4e4ae3daf77c52c05b
> 3rdparty/stout/include/stout/os/windows/mkdtemp.hpp f742f0838cdc5132286f55775ca042ce8057c166
> 3rdparty/stout/include/stout/os/windows/mktemp.hpp b4f5279a58274f02b260bdb3b94c284547842a0f
> 3rdparty/stout/include/stout/os/windows/open.hpp b2f033c19027144083dc02cf3d4081b1fb26b501
> 3rdparty/stout/include/stout/os/windows/realpath.hpp 6bfaaf63f849129793b5b3e2d501623ec83e9d4f
> 3rdparty/stout/include/stout/os/windows/rename.hpp 523912ac3bf315f70f542e8eab7d2d02249909b4
> 3rdparty/stout/include/stout/os/windows/rm.hpp 2cacb28ec534e0f3e213d04ddf56168bc2061901
> 3rdparty/stout/include/stout/os/windows/rmdir.hpp 00821cdb62a02824e26ddb125eca66694165ce1f
> 3rdparty/stout/include/stout/os/windows/shell.hpp b9e06d667159d2fb5e266ce7f7e633deb1237a78
> 3rdparty/stout/include/stout/os/windows/stat.hpp 62256094b9a58779e28dd78f1281a7d8bd7955d0
> 3rdparty/stout/include/stout/os/windows/su.hpp ac3a8968f7b9fe6889e13aa47595ae45a094c891
> 3rdparty/stout/include/stout/os/windows/temp.hpp 4e8543ee6b67f0c2b50a858826e19eed211452bc
> 3rdparty/stout/include/stout/windows/net.hpp 74398637fe830af0655b1358d4ea52d259a97e9e
> 3rdparty/stout/include/stout/windows/os.hpp 4f26806e4e027c090c6e7ce07b1bb8d2dabfb531
>
>
> Diff: https://reviews.apache.org/r/68175/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Liangyu Zhao
>
>
Re: Review Request 68175: Windows: Change strings in Windows os code
to `wstring`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68175/#review206832
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68174', '68175']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2034/mesos-review-68175
Relevant logs:
- [stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2034/mesos-review-68175/logs/stout-tests-stdout.log):
```
[ RUN ] SocketTests.InitSocket
[ OK ] SocketTests.InitSocket (1 ms)
[ RUN ] SocketTests.IntFD
[ OK ] SocketTests.IntFD (1 ms)
[----------] 2 tests from SocketTests (5 ms total)
[----------] 2 tests from StrerrorTest
[ RUN ] StrerrorTest.ValidErrno
[ OK ] StrerrorTest.ValidErrno (0 ms)
[ RUN ] StrerrorTest.InvalidErrno
[ OK ] StrerrorTest.InvalidErrno (0 ms)
[----------] 2 tests from StrerrorTest (2 ms total)
[----------] 2 tests from OsSendfileTest
[ RUN ] OsSendfileTest.Sendfile
[ OK ] OsSendfileTest.Sendfile (1256 ms)
[ RUN ] OsSendfileTest.SendfileAsync
[ OK ] OsSendfileTest.SendfileAsync (22 ms)
[----------] 2 tests from OsSendfileTest (1280 ms total)
[----------] Global test environment tear-down
[==========] 333 tests from 52 test cases ran. (6185 ms total)
[ PASSED ] 332 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] OsTest.SYMLINK_Size
1 FAILED TEST
YOU HAVE 1 DISABLED TEST
```
- [stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2034/mesos-review-68175/logs/stout-tests-stderr.log):
```
'invalid.command' is not recognized as an internal or external command,
operable program or batch file.
Subcommand 'subcommand' is not available
Usage: command <subcommand> [OPTIONS]
Available subcommands:
help
subcommand2
Multiple subcommands have name 'subcommand'
```
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2034/mesos-review-68175/logs/mesos-tests-stdout.log):
```
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (30 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (69 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (1667 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (1688 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (1393 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (1413 ms total)
[----------] Global test environment tear-down
[==========] 1013 tests from 98 test cases ran. (854525 ms total)
[ PASSED ] 1009 tests.
[ FAILED ] 4 tests, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
[ FAILED ] DockerTest.ROOT_DOCKER_interface
[ FAILED ] DockerTest.ROOT_DOCKER_CheckPortResource
[ FAILED ] DockerTest.ROOT_DOCKER_MountRelativeHostPath
4 FAILED TESTS
YOU HAVE 222 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2034/mesos-review-68175/logs/mesos-tests-stderr.log):
```
I0803 01:43:29.282469 9860 slave.cpp:3939] Shutting down framework 6f97b4e3-1042-4667-8920-566a098d0e00-0000
I0803 01:43:29.282469 12008 master.cpp:10906] Updating the state of task c45bbcf8-62d4-44d1-a22f-a459416377fc of framework 6f97b4e3-1042-4667-8920-566a098d0e00-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0803 01:43:29.282469 9860 slave.cpp:6658] Shutting down executor 'c45bbcf8-62d4-44d1-a22f-a459416377fc' of framework 6f97b4e3-1042-4667-8920-566a098d0e00-0000 at executor(1)@192.10.1.6:55084
I0803 01:43:29.284461 9860 slave.cpp:931] Agent terminating
W0803 01:43:29.284461 9860 slave.cpp:3935] Ignoring shutdown framework 6f97b4e3-1042-4667-8920-566a098d0e00-0000 because it is terminating
I0803 01:43:29.285466 12008 master.cpp:11004] Removing task c45bbcf8-62d4-44d1-a22f-a459416377fc with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 6f97bI0803 01:43:28.857455 8312 exec.cpp:162] Version: 1.7.0
I0803 01:43:28.883463 15688 exec.cpp:236] Executor registered on agent 6f97b4e3-1042-4667-8920-566a098d0e00-S0
I0803 01:43:28.888476 13588 executor.cpp:182] Received SUBSCRIBED event
I0803 01:43:28.893471 13588 executor.cpp:186] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0803 01:43:28.894474 13588 executor.cpp:182] Received LAUNCH event
I0803 01:43:28.900457 13588 executor.cpp:679] Starting task c45bbcf8-62d4-44d1-a22f-a459416377fc
I0803 01:43:29.012468 13588 executor.cpp:499] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0803 01:43:29.253463 13588 executor.cpp:693] Forked command at 3808
I0803 01:43:29.284461 15688 exec.cpp:445] Executor asked to shutdown
I0803 01:43:29.285466 13588 executor.cpp:182] Received SHUTDOWN event
I0803 01:43:29.285466 13588 executor.cpp:796] Shutting down
I0803 01:43:29.285466 13588 executor.cpp:909] Sending SIGTERM to process tree at pid 3804e3-1042-4667-8920-566a098d0e00-0000 on agent 6f97b4e3-1042-4667-8920-566a098d0e00-S0 at slave(462)@192.10.1.6:53368 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0803 01:43:29.288462 12008 master.cpp:1281] Agent 6f97b4e3-1042-4667-8920-566a098d0e00-S0 at slave(462)@192.10.1.6:53368 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0803 01:43:29.288462 12008 master.cpp:3297] Disconnecting agent 6f97b4e3-1042-4667-8920-566a098d0e00-S0 at slave(462)@192.10.1.6:53368 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0803 01:43:29.289465 12008 master.cpp:3316] Deactivating agent 6f97b4e3-1042-4667-8920-566a098d0e00-S0 at slave(462)@192.10.1.6:53368 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0803 01:43:29.289465 9580 hierarchical.cpp:359] Removed framework 6f97b4e3-1042-4667-8920-566a098d0e00-0000
I0803 01:43:29.289465 16236 containerizer.cpp:2407] Destroying container 35be7939-460e-4e0a-b879-2196dd97da3c in RUNNING state
I0803 01:43:29.289465 16236 containerizer.cpp:3021] Transitioning the state of container 35be7939-460e-4e0a-b879-2196dd97da3c from RUNNING to DESTROYING
I0803 01:43:29.289465 9580 hierarchical.cpp:795] Agent 6f97b4e3-1042-4667-8920-566a098d0e00-S0 deactivated
I0803 01:43:29.290459 16236 launcher.cpp:155] Asked to destroy container 35be7939-460e-4e0a-b879-2196dd97da3c
I0803 01:43:29.371457 16300 containerizer.cpp:2860] Container 35be7939-460e-4e0a-b879-2196dd97da3c has exited
I0803 01:43:29.399456 15980 master.cpp:1123] Master terminating
I0803 01:43:29.401459 6008 hierarchical.cpp:637] Removed agent 6f97b4e3-1042-4667-8920-566a098d0e00-S0
I0803 01:43:29.692468 10760 process.cpp:926] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Aug. 2, 2018, 9:31 p.m., Liangyu Zhao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68175/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2018, 9:31 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Functions in `stout/internal/windows` and `stout/os/windows` now use
> `std::wstring` instead of `std::string`. Narrow string is still
> supported, but will converted to wide string for process. The return
> values for functions are unchanged.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/internal/windows/attributes.hpp 673b744588fee32aa4c462199be0675c392636fb
> 3rdparty/stout/include/stout/internal/windows/longpath.hpp 499eef30a3d16ac1f6c2e3334ef773e91e987a45
> 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 280956ff9cfb0efcc5b0aa7ef35473122d9dd8c0
> 3rdparty/stout/include/stout/internal/windows/symlink.hpp def5515656a5a454655d6a484c7e52ea12be8a55
> 3rdparty/stout/include/stout/os/constants.hpp f81dbb3b7dcd929475324047f32cbabd873bea81
> 3rdparty/stout/include/stout/os/windows/chdir.hpp 523c7f75bd120b00f815c4c4aac946fdb5dbaaa5
> 3rdparty/stout/include/stout/os/windows/copyfile.hpp 34723bce9a151582de481d63a865509d4d29c02c
> 3rdparty/stout/include/stout/os/windows/exists.hpp 50bb92a1e4100a89a346d6bafc6d4133e6e40589
> 3rdparty/stout/include/stout/os/windows/getcwd.hpp daf131ac1da705724e85cd236c68685422d2f3c8
> 3rdparty/stout/include/stout/os/windows/getenv.hpp 034510cff3701f1063c4fa7ff5c0acb63b421717
> 3rdparty/stout/include/stout/os/windows/ls.hpp 68d5a6037c4c73d6233829259e4fceb4db613a0c
> 3rdparty/stout/include/stout/os/windows/mkdir.hpp 2aef22a47a80eddc9db0cd4e4ae3daf77c52c05b
> 3rdparty/stout/include/stout/os/windows/mkdtemp.hpp f742f0838cdc5132286f55775ca042ce8057c166
> 3rdparty/stout/include/stout/os/windows/mktemp.hpp b4f5279a58274f02b260bdb3b94c284547842a0f
> 3rdparty/stout/include/stout/os/windows/open.hpp b2f033c19027144083dc02cf3d4081b1fb26b501
> 3rdparty/stout/include/stout/os/windows/realpath.hpp 6bfaaf63f849129793b5b3e2d501623ec83e9d4f
> 3rdparty/stout/include/stout/os/windows/rename.hpp 523912ac3bf315f70f542e8eab7d2d02249909b4
> 3rdparty/stout/include/stout/os/windows/rm.hpp 2cacb28ec534e0f3e213d04ddf56168bc2061901
> 3rdparty/stout/include/stout/os/windows/rmdir.hpp 00821cdb62a02824e26ddb125eca66694165ce1f
> 3rdparty/stout/include/stout/os/windows/shell.hpp b9e06d667159d2fb5e266ce7f7e633deb1237a78
> 3rdparty/stout/include/stout/os/windows/stat.hpp 62256094b9a58779e28dd78f1281a7d8bd7955d0
> 3rdparty/stout/include/stout/os/windows/su.hpp ac3a8968f7b9fe6889e13aa47595ae45a094c891
> 3rdparty/stout/include/stout/os/windows/temp.hpp 4e8543ee6b67f0c2b50a858826e19eed211452bc
> 3rdparty/stout/include/stout/windows/net.hpp 74398637fe830af0655b1358d4ea52d259a97e9e
> 3rdparty/stout/include/stout/windows/os.hpp 4f26806e4e027c090c6e7ce07b1bb8d2dabfb531
>
>
> Diff: https://reviews.apache.org/r/68175/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Liangyu Zhao
>
>