You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "schnappi17 (via GitHub)" <gi...@apache.org> on 2024/03/06 04:53:50 UTC

[PR] [core] Fix collecting wrong sorted runs when compacting on custom branch [incubator-paimon]

schnappi17 opened a new pull request, #2950:
URL: https://github.com/apache/incubator-paimon/pull/2950

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: subtask #2861 
   
   <!-- What is the purpose of the change -->
   When writing to a custom branch, the compaction within writer will picking the wrong sorted runs on the 'main' branch to compact, which will cause the commit conflict, like willing to delete files which never been added.
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Fix collecting wrong sorted runs when compacting on custom branch [incubator-paimon]

Posted by "schnappi17 (via GitHub)" <gi...@apache.org>.
schnappi17 commented on code in PR #2950:
URL: https://github.com/apache/incubator-paimon/pull/2950#discussion_r1516023684


##########
paimon-core/src/main/java/org/apache/paimon/operation/AbstractFileStoreWrite.java:
##########


Review Comment:
   @sunxiaojian You mean the calculation of `latestCommittedIdentifier`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Fix collecting wrong sorted runs when compacting on custom branch [incubator-paimon]

Posted by "sunxiaojian (via GitHub)" <gi...@apache.org>.
sunxiaojian commented on code in PR #2950:
URL: https://github.com/apache/incubator-paimon/pull/2950#discussion_r1515463362


##########
paimon-core/src/main/java/org/apache/paimon/operation/AbstractFileStoreWrite.java:
##########


Review Comment:
   @schnappi17  Does prepareCommit() also need to be processed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Fix collecting wrong sorted runs when compacting on custom branch [paimon]

Posted by "schnappi17 (via GitHub)" <gi...@apache.org>.
schnappi17 closed pull request #2950: [core] Fix collecting wrong sorted runs when compacting on custom branch
URL: https://github.com/apache/paimon/pull/2950


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Fix collecting wrong sorted runs when compacting on custom branch [incubator-paimon]

Posted by "sunxiaojian (via GitHub)" <gi...@apache.org>.
sunxiaojian commented on PR #2950:
URL: https://github.com/apache/incubator-paimon/pull/2950#issuecomment-2002034543

   @schnappi17 If https://github.com/apache/incubator-paimon/pull/3029 Merged, do we no longer need the current processing method ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Fix collecting wrong sorted runs when compacting on custom branch [paimon]

Posted by "schnappi17 (via GitHub)" <gi...@apache.org>.
schnappi17 commented on PR #2950:
URL: https://github.com/apache/paimon/pull/2950#issuecomment-2136692765

   Fixed in https://github.com/apache/paimon/pull/3029, close this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Fix collecting wrong sorted runs when compacting on custom branch [incubator-paimon]

Posted by "sunxiaojian (via GitHub)" <gi...@apache.org>.
sunxiaojian commented on code in PR #2950:
URL: https://github.com/apache/incubator-paimon/pull/2950#discussion_r1516073459


##########
paimon-core/src/main/java/org/apache/paimon/operation/AbstractFileStoreWrite.java:
##########


Review Comment:
   > You mean the calculation of `latestCommittedIdentifier`?
   
   @schnappi17 yes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org