You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2017/10/06 15:19:58 UTC
svn commit: r1811344 - in /commons/proper/codec/trunk/src:
main/java/org/apache/commons/codec/binary/
main/java/org/apache/commons/codec/cli/
main/java/org/apache/commons/codec/digest/
main/java/org/apache/commons/codec/language/ main/java/org/apache/c...
Author: ggregory
Date: Fri Oct 6 15:19:57 2017
New Revision: 1811344
URL: http://svn.apache.org/viewvc?rev=1811344&view=rev
Log:
Add final modifier to method parameters
Modified:
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Hex.java
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/cli/Digest.java
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/HmacUtils.java
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32.java
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32C.java
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/XXHash32.java
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/Soundex.java
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/Utils.java
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/Base32Test.java
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/Base64Test.java
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/HmacAlgorithmsTest.java
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32CTest.java
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/XXHash32Test.java
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java Fri Oct 6 15:19:57 2017
@@ -444,7 +444,7 @@ public abstract class BaseNCodec impleme
* @return A byte array containing only the base N alphabetic character data
* @since 1.11
*/
- public byte[] encode(final byte[] pArray, int offset, int length) {
+ public byte[] encode(final byte[] pArray, final int offset, final int length) {
if (pArray == null || pArray.length == 0) {
return pArray;
}
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Hex.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Hex.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Hex.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Hex.java Fri Oct 6 15:19:57 2017
@@ -76,7 +76,7 @@ public class Hex implements BinaryEncode
* Thrown if an odd number or illegal of characters is supplied
* @since 1.11
*/
- public static byte[] decodeHex(String data) throws DecoderException {
+ public static byte[] decodeHex(final String data) throws DecoderException {
return decodeHex(data.toCharArray());
}
@@ -237,7 +237,7 @@ public class Hex implements BinaryEncode
* @return A String containing lower-case hexadecimal characters
* @since 1.11
*/
- public static String encodeHexString(final byte[] data, boolean toLowerCase) {
+ public static String encodeHexString(final byte[] data, final boolean toLowerCase) {
return new String(encodeHex(data, toLowerCase));
}
@@ -265,7 +265,7 @@ public class Hex implements BinaryEncode
* @return A String containing lower-case hexadecimal characters
* @since 1.11
*/
- public static String encodeHexString(final ByteBuffer data, boolean toLowerCase) {
+ public static String encodeHexString(final ByteBuffer data, final boolean toLowerCase) {
return new String(encodeHex(data, toLowerCase));
}
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/cli/Digest.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/cli/Digest.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/cli/Digest.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/cli/Digest.java Fri Oct 6 15:19:57 2017
@@ -49,7 +49,7 @@ public class Digest {
* {@code args[1+]} is a FILE/DIRECTORY/String.
* @throws IOException if an error occurs
*/
- public static void main(String[] args) throws IOException {
+ public static void main(final String[] args) throws IOException {
new Digest(args).run();
}
@@ -79,7 +79,7 @@ public class Digest {
println(prefix, digest, null);
}
- private void println(final String prefix, final byte[] digest, String fileName) {
+ private void println(final String prefix, final byte[] digest, final String fileName) {
// The standard appears to be to print
// hex, space, then either space or '*' followed by filename
// where '*' is used for binary files
@@ -101,7 +101,7 @@ public class Digest {
}
}
- private void run(String[] digestAlgorithms) throws IOException {
+ private void run(final String[] digestAlgorithms) throws IOException {
for (final String messageDigestAlgorithm : digestAlgorithms) {
if (DigestUtils.isAvailable(messageDigestAlgorithm)) {
run(messageDigestAlgorithm + " ", messageDigestAlgorithm);
@@ -109,7 +109,7 @@ public class Digest {
}
}
- private void run(String prefix, final MessageDigest messageDigest) throws IOException {
+ private void run(final String prefix, final MessageDigest messageDigest) throws IOException {
if (inputs == null) {
println(prefix, DigestUtils.digest(messageDigest, System.in));
return;
@@ -131,7 +131,7 @@ public class Digest {
}
}
- private void run(String prefix, MessageDigest messageDigest, File[] files) throws IOException {
+ private void run(final String prefix, final MessageDigest messageDigest, final File[] files) throws IOException {
for (final File file : files) {
if (file.isFile()) {
println(prefix, DigestUtils.digest(messageDigest, file), file.getName());
@@ -139,7 +139,7 @@ public class Digest {
}
}
- private void run(String prefix, final String messageDigestAlgorithm) throws IOException {
+ private void run(final String prefix, final String messageDigestAlgorithm) throws IOException {
run(prefix, DigestUtils.getDigest(messageDigestAlgorithm));
}
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java Fri Oct 6 15:19:57 2017
@@ -154,7 +154,7 @@ public class DigestUtils {
* when a {@link NoSuchAlgorithmException} is caught.
* @since 1.11
*/
- public static MessageDigest getDigest(final String algorithm, MessageDigest defaultMessageDigest) {
+ public static MessageDigest getDigest(final String algorithm, final MessageDigest defaultMessageDigest) {
try {
return MessageDigest.getInstance(algorithm);
} catch (final Exception e) {
@@ -955,7 +955,7 @@ public class DigestUtils {
* @return {@code true} if the algorithm can be found
* @since 1.11
*/
- public static boolean isAvailable(String messageDigestAlgorithm) {
+ public static boolean isAvailable(final String messageDigestAlgorithm) {
return getDigest(messageDigestAlgorithm, null) != null;
}
@@ -980,7 +980,7 @@ public class DigestUtils {
* @param digest the {@link MessageDigest} to use
* @since 1.11
*/
- public DigestUtils(MessageDigest digest) {
+ public DigestUtils(final MessageDigest digest) {
this.messageDigest = digest;
}
@@ -996,7 +996,7 @@ public class DigestUtils {
* when a {@link NoSuchAlgorithmException} is caught.
* @since 1.11
*/
- public DigestUtils(String name) {
+ public DigestUtils(final String name) {
this(getDigest(name));
}
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/HmacUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/HmacUtils.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/HmacUtils.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/HmacUtils.java Fri Oct 6 15:19:57 2017
@@ -65,7 +65,7 @@ public final class HmacUtils {
* @return whether this algorithm is available
* @since 1.11
*/
- public static boolean isAvailable(String name) {
+ public static boolean isAvailable(final String name) {
try {
Mac.getInstance(name);
return true;
@@ -81,7 +81,7 @@ public final class HmacUtils {
* @return whether this algorithm is available
* @since 1.11
*/
- public static boolean isAvailable(HmacAlgorithms name) {
+ public static boolean isAvailable(final HmacAlgorithms name) {
try {
Mac.getInstance(name.getName());
return true;
@@ -954,7 +954,7 @@ public final class HmacUtils {
* @return the digest as a byte[]
* @since 1.11
*/
- public byte[] hmac(byte[] valueToDigest) {
+ public byte[] hmac(final byte[] valueToDigest) {
return mac.doFinal(valueToDigest);
}
@@ -965,7 +965,7 @@ public final class HmacUtils {
* @return the digest as a hex String
* @since 1.11
*/
- public String hmacHex(byte[] valueToDigest) {
+ public String hmacHex(final byte[] valueToDigest) {
return Hex.encodeHexString(hmac(valueToDigest));
}
@@ -976,7 +976,7 @@ public final class HmacUtils {
* @return the digest as a byte[]
* @since 1.11
*/
- public byte[] hmac(String valueToDigest) {
+ public byte[] hmac(final String valueToDigest) {
return mac.doFinal(StringUtils.getBytesUtf8(valueToDigest));
}
@@ -987,7 +987,7 @@ public final class HmacUtils {
* @return the digest as a hex String
* @since 1.11
*/
- public String hmacHex(String valueToDigest) {
+ public String hmacHex(final String valueToDigest) {
return Hex.encodeHexString(hmac(valueToDigest));
}
@@ -998,7 +998,7 @@ public final class HmacUtils {
* @return the digest as a byte[]
* @since 1.11
*/
- public byte[] hmac(ByteBuffer valueToDigest) {
+ public byte[] hmac(final ByteBuffer valueToDigest) {
mac.update(valueToDigest);
return mac.doFinal();
}
@@ -1010,7 +1010,7 @@ public final class HmacUtils {
* @return the digest as a hex String
* @since 1.11
*/
- public String hmacHex(ByteBuffer valueToDigest) {
+ public String hmacHex(final ByteBuffer valueToDigest) {
return Hex.encodeHexString(hmac(valueToDigest));
}
@@ -1027,7 +1027,7 @@ public final class HmacUtils {
* If an I/O error occurs.
* @since 1.11
*/
- public byte[] hmac(InputStream valueToDigest) throws IOException {
+ public byte[] hmac(final InputStream valueToDigest) throws IOException {
final byte[] buffer = new byte[STREAM_BUFFER_LENGTH];
int read;
@@ -1050,7 +1050,7 @@ public final class HmacUtils {
* If an I/O error occurs.
* @since 1.11
*/
- public String hmacHex(InputStream valueToDigest) throws IOException {
+ public String hmacHex(final InputStream valueToDigest) throws IOException {
return Hex.encodeHexString(hmac(valueToDigest));
}
@@ -1081,7 +1081,7 @@ public final class HmacUtils {
* If an I/O error occurs.
* @since 1.11
*/
- public String hmacHex(File valueToDigest) throws IOException {
+ public String hmacHex(final File valueToDigest) throws IOException {
return Hex.encodeHexString(hmac(valueToDigest));
}
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32.java Fri Oct 6 15:19:57 2017
@@ -99,7 +99,7 @@ public class PureJavaCrc32 implements Ch
}
@Override
- final public void update(int b) {
+ final public void update(final int b) {
crc = (crc >>> 8) ^ T[(((crc ^ b) << 24) >>> 24)];
}
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32C.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32C.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32C.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32C.java Fri Oct 6 15:19:57 2017
@@ -57,7 +57,7 @@ public class PureJavaCrc32C implements C
}
@Override
- public void update(byte[] b, int off, int len) {
+ public void update(final byte[] b, int off, int len) {
int localCrc = crc;
while(len > 7) {
@@ -98,7 +98,7 @@ public class PureJavaCrc32C implements C
}
@Override
- final public void update(int b) {
+ final public void update(final int b) {
crc = (crc >>> 8) ^ T[T8_0_start + ((crc ^ b) & 0xff)];
}
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/XXHash32.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/XXHash32.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/XXHash32.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/XXHash32.java Fri Oct 6 15:19:57 2017
@@ -64,7 +64,7 @@ public class XXHash32 implements Checksu
* Creates an XXHash32 instance.
* @param seed the seed to use
*/
- public XXHash32(int seed) {
+ public XXHash32(final int seed) {
this.seed = seed;
initializeState();
}
@@ -77,13 +77,13 @@ public class XXHash32 implements Checksu
}
@Override
- public void update(int b) {
+ public void update(final int b) {
oneByte[0] = (byte) (b & 0xff);
update(oneByte, 0, 1);
}
@Override
- public void update(byte[] b, int off, final int len) {
+ public void update(final byte[] b, int off, final int len) {
if (len <= 0) {
return;
}
@@ -147,7 +147,7 @@ public class XXHash32 implements Checksu
return hash & 0xffffffffl;
}
- private static int getInt(byte[] buffer, int idx) {
+ private static int getInt(final byte[] buffer, final int idx) {
return (int) (fromLittleEndian(buffer, idx, 4) & 0xffffffffl);
}
@@ -158,7 +158,7 @@ public class XXHash32 implements Checksu
state[3] = seed - PRIME1;
}
- private void process(byte[] b, int offset) {
+ private void process(final byte[] b, final int offset) {
// local shadows for performance
int s0 = state[0];
int s1 = state[1];
@@ -186,7 +186,7 @@ public class XXHash32 implements Checksu
* @return the number read
* @throws IllegalArgumentException if len is bigger than eight
*/
- private static long fromLittleEndian(byte[] bytes, final int off, final int length) {
+ private static long fromLittleEndian(final byte[] bytes, final int off, final int length) {
if (length > 8) {
throw new IllegalArgumentException("can't read more than eight bytes into a long value");
}
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/Soundex.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/Soundex.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/Soundex.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/Soundex.java Fri Oct 6 15:19:57 2017
@@ -159,7 +159,7 @@ public class Soundex implements StringEn
this.specialCaseHW = !hasMarker(this.soundexMapping);
}
- private boolean hasMarker(char[] mapping) {
+ private boolean hasMarker(final char[] mapping) {
for(final char ch : mapping) {
if (ch == SILENT_MARKER) {
return true;
@@ -192,7 +192,7 @@ public class Soundex implements StringEn
* @param specialCaseHW if true, then
* @since 1.11
*/
- public Soundex(final String mapping, boolean specialCaseHW) {
+ public Soundex(final String mapping, final boolean specialCaseHW) {
this.soundexMapping = mapping.toCharArray();
this.specialCaseHW = specialCaseHW;
}
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/Utils.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/Utils.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/Utils.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/Utils.java Fri Oct 6 15:19:57 2017
@@ -58,7 +58,7 @@ class Utils {
* @param b the input int
* @return the upper case hex digit of the lower 4 bits of the int.
*/
- static char hexDigit(int b) {
+ static char hexDigit(final int b) {
return Character.toUpperCase(Character.forDigit(b & 0xF, RADIX));
}
Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/Base32Test.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/Base32Test.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/Base32Test.java (original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/Base32Test.java Fri Oct 6 15:19:57 2017
@@ -111,7 +111,7 @@ public class Base32Test {
testBase64InBuffer(100, 100);
}
- private void testBase64InBuffer(int startPasSize, int endPadSize) {
+ private void testBase64InBuffer(final int startPasSize, final int endPadSize) {
final Base32 codec = new Base32();
for (final String[] element : BASE32_TEST_CASES) {
final byte[] bytes = element[0].getBytes(CHARSET_UTF8);
Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/Base64Test.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/Base64Test.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/Base64Test.java (original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/Base64Test.java Fri Oct 6 15:19:57 2017
@@ -124,7 +124,7 @@ public class Base64Test {
testBase64InBuffer(100, 100);
}
- private void testBase64InBuffer(int startPasSize, int endPadSize) {
+ private void testBase64InBuffer(final int startPasSize, final int endPadSize) {
final String content = "Hello World";
String encodedContent;
final byte[] bytesUtf8 = StringUtils.getBytesUtf8(content);
Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java (original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java Fri Oct 6 15:19:57 2017
@@ -105,7 +105,7 @@ public class HexTest {
}
}
- private void checkDecodeHexCharArrayOddCharacters(String data) {
+ private void checkDecodeHexCharArrayOddCharacters(final String data) {
try {
Hex.decodeHex(data);
fail("An exception wasn't thrown when trying to decode an odd number of characters");
Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/HmacAlgorithmsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/HmacAlgorithmsTest.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/HmacAlgorithmsTest.java (original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/HmacAlgorithmsTest.java Fri Oct 6 15:19:57 2017
@@ -99,7 +99,7 @@ public class HmacAlgorithmsTest {
private final byte[] standardResultBytes;
private final String standardResultString;
- public HmacAlgorithmsTest(HmacAlgorithms hmacAlgorithm, byte[] standardResultBytes, String standardResultString) {
+ public HmacAlgorithmsTest(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) {
Assume.assumeTrue(HmacUtils.isAvailable(hmacAlgorithm));
this.hmacAlgorithm = hmacAlgorithm;
this.standardResultBytes = standardResultBytes;
Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java (original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java Fri Oct 6 15:19:57 2017
@@ -48,7 +48,7 @@ public class MessageDigestAlgorithmsTest
return MessageDigestAlgorithms.values();
}
- private static boolean contains(String key) {
+ private static boolean contains(final String key) {
for(final String s : MessageDigestAlgorithms.values()) {
if (s.equals(key)) {
return true;
@@ -85,7 +85,7 @@ public class MessageDigestAlgorithmsTest
private final String messageDigestAlgorithm;
- public MessageDigestAlgorithmsTest(String messageDigestAlgorithm) {
+ public MessageDigestAlgorithmsTest(final String messageDigestAlgorithm) {
this.messageDigestAlgorithm = messageDigestAlgorithm;
}
Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32CTest.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32CTest.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32CTest.java (original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32CTest.java Fri Oct 6 15:19:57 2017
@@ -63,7 +63,7 @@ public class PureJavaCrc32CTest {
}
// Using int because only want 32 bits
- private void check(int expected) {
+ private void check(final int expected) {
crc.reset();
crc.update(data, 0, data.length);
final int actual = (int) crc.getValue();
Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java (original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java Fri Oct 6 15:19:57 2017
@@ -64,7 +64,7 @@ public class PureJavaCrc32Test {
}
- private void checkOnBytes(byte[] bytes, boolean print) {
+ private void checkOnBytes(final byte[] bytes, final boolean print) {
theirs.reset();
ours.reset();
checkSame();
@@ -111,7 +111,7 @@ public class PureJavaCrc32Test {
private final int[][] tables;
private Table(final int nBits, final int nTables,
- long polynomial) {
+ final long polynomial) {
tables = new int[nTables][];
final int size = 1 << nBits;
for(int i = 0; i < tables.length; i++) {
@@ -144,7 +144,7 @@ public class PureJavaCrc32Test {
}
}
- String[] toStrings(String nameformat) {
+ String[] toStrings(final String nameformat) {
final String[] s = new String[tables.length];
for (int j = 0; j < tables.length; j++) {
final int[] t = tables[j];
@@ -185,7 +185,7 @@ public class PureJavaCrc32Test {
}
/** Generate CRC-32 lookup tables */
- public static void main(String[] args) throws FileNotFoundException {
+ public static void main(final String[] args) throws FileNotFoundException {
if (args.length != 1) {
System.err.println("Usage: " + Table.class.getName() +
" <polynomial>");
@@ -231,12 +231,12 @@ public class PureJavaCrc32Test {
}
- public static void main(String args[]) throws Exception {
+ public static void main(final String args[]) throws Exception {
printSystemProperties(System.out);
doBench(CRCS, System.out);
}
- private static void printCell(String s, int width, PrintStream out) {
+ private static void printCell(final String s, final int width, final PrintStream out) {
final int w = s.length() > width? s.length(): width;
out.printf(" %" + w + "s |", s);
}
@@ -315,7 +315,7 @@ public class PureJavaCrc32Test {
}
}
- private static BenchResult doBench(Class<? extends Checksum> clazz,
+ private static BenchResult doBench(final Class<? extends Checksum> clazz,
final int numThreads, final byte[] bytes, final int size)
throws Exception {
@@ -371,13 +371,13 @@ public class PureJavaCrc32Test {
/** Speed (MB per second) */
final double mbps;
- BenchResult(long value, double mbps) {
+ BenchResult(final long value, final double mbps) {
this.value = value;
this.mbps = mbps;
}
}
- private static void printSystemProperties(PrintStream out) {
+ private static void printSystemProperties(final PrintStream out) {
final String[] names = {
"java.version",
"java.runtime.name",
Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/XXHash32Test.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/XXHash32Test.java?rev=1811344&r1=1811343&r2=1811344&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/XXHash32Test.java (original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/XXHash32Test.java Fri Oct 6 15:19:57 2017
@@ -42,7 +42,7 @@ public class XXHash32Test {
private final File file;
private final String expectedChecksum;
- public XXHash32Test(String path, String c) throws IOException {
+ public XXHash32Test(final String path, final String c) throws IOException {
final URL url = XXHash32Test.class.getClassLoader().getResource(path);
if (url == null) {
throw new FileNotFoundException("couldn't find " + path);