You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/01/07 20:56:44 UTC
[GitHub] rfscholte commented on a change in pull request #153: [MNG-6069]
Migrate to non deprecated parts of Commons CLI
rfscholte commented on a change in pull request #153: [MNG-6069] Migrate to non deprecated parts of Commons CLI
URL: https://github.com/apache/maven/pull/153#discussion_r245794401
##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java
##########
@@ -167,7 +170,7 @@ public void displayHelp( PrintStream stdout )
HelpFormatter formatter = new HelpFormatter();
- formatter.printHelp( pw, HelpFormatter.DEFAULT_WIDTH, "mvn [options] [<goal(s)>] [<phase(s)>]", "\nOptions:",
+ formatter.printHelp( pw, 120, "mvn [options] [<goal(s)>] [<phase(s)>]", "\nOptions:",
Review comment:
+1, I see no reason why to replace this. I would expect SonarQube to complain about magic numbers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services