You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/06/27 21:31:27 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #20665: [improve][build] Build function-go in golang image
tisonkun opened a new pull request, #20665:
URL: https://github.com/apache/pulsar/pull/20665
### Motivation
We don't need to download and configure Golang manually. We don't depend on any build artifacts but function-go's source.
Let's simplify the Dockerfile.
### Modifications
Use golang base image to build function-go examples.
### Verifying this change
Should be a seamless refactor.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #20665: [improve][build] Build function-go in golang image
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #20665:
URL: https://github.com/apache/pulsar/pull/20665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20665: [improve][build] Build function-go in golang image
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20665:
URL: https://github.com/apache/pulsar/pull/20665#issuecomment-1612355720
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#20665](https://app.codecov.io/gh/apache/pulsar/pull/20665?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (440faf4) into [master](https://app.codecov.io/gh/apache/pulsar/commit/2b01f83ea4f3ab7b22f4ea2b0290cc183e79bbb8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2b01f83) will **increase** coverage by `39.44%`.
> The diff coverage is `n/a`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #20665 +/- ##
=============================================
+ Coverage 33.58% 73.03% +39.44%
- Complexity 12127 31974 +19847
=============================================
Files 1613 1867 +254
Lines 126241 138683 +12442
Branches 13770 15240 +1470
=============================================
+ Hits 42396 101283 +58887
+ Misses 78331 29358 -48973
- Partials 5514 8042 +2528
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.11% <ø> (-0.08%)` | :arrow_down: |
| systests | `25.07% <ø> (?)` | |
| unittests | `72.31% <ø> (+40.27%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1521 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20665/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #20665: [improve][build] Build function-go in golang image
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #20665:
URL: https://github.com/apache/pulsar/pull/20665#issuecomment-1612323355
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #20665: [improve][build] Build function-go in golang image
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #20665:
URL: https://github.com/apache/pulsar/pull/20665#issuecomment-1612375329
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org