You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "chstercc (via GitHub)" <gi...@apache.org> on 2026/09/29 09:20:25 UTC
[PR] test(llm): cover empty fallback model options [rocketmq-dashboard]
chstercc opened a new pull request, #5146:
URL: https://github.com/apache/rocketmq-dashboard/pull/5146
### Which Issue(s) This PR Fixes
- Fixes #4032
### Brief Description
Add a regression test confirming that an unknown LLM provider with no current model returns an empty list of fallback model options. No runtime behavior changes.
### How Did You Test This Change?
From `web/`:
- `npm test -- src/pages/studio/__tests__/LlmSettings.test.ts` — 5 tests passed.
- `npm run lint` — passed with 0 errors and 11 warnings in unchanged files.
- `npm test` — 1361 tests passed; one unrelated `TopicPage` test timed out and passed when rerun alone.
- `npm run build` — TypeScript and Vite completed; the subsequent license check failed on generated `assets/index-KHFZJnrL.js`.
- Confirmed the new test fails when the covered filtering behavior is removed.
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits (`test(llm): ...`)
- [x] Regression test added; the `...Test` method naming convention does not apply to this Vitest test
- [x] No new UI text
- [x] No backend or architecture changes
- [x] No new source files
- [x] No behavior or documentation changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(llm): cover empty fallback model options [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5146: test(llm): cover empty fallback model options
URL: https://github.com/apache/rocketmq-dashboard/pull/5146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(llm): cover empty fallback model options [rocketmq-dashboard]
Posted by "chstercc (via GitHub)" <gi...@apache.org>.
chstercc commented on PR #5146:
URL: https://github.com/apache/rocketmq-dashboard/pull/5146#issuecomment-5930488370
Removed the unrelated group-detail changes and reset the branch to d444254e7. This PR now contains only the four-line LLM regression test. Ready for re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(llm): cover empty fallback model options [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5146:
URL: https://github.com/apache/rocketmq-dashboard/pull/5146#issuecomment-6115553185
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org