[PR] Refactor LALOutputBuilder.init() to take ModuleManager instead of NamingControl [skywalking]

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng opened a new pull request, #13741:
URL: https://github.com/apache/skywalking/pull/13741

   ### Refactor LALOutputBuilder to self-resolve services from ModuleManager
   - [x] Tests updated to match new interface.
   
   Move service resolution (`NamingControl`, `searchableTagKeys`) from `RecordSinkListener` into each `LALOutputBuilder` implementation. This removes the `instanceof LogBuilder` check and Log-specific concerns from the general-purpose `RecordSinkListener`.
   
   **Key changes:**
   - `LALOutputBuilder.init()` signature: `NamingControl` → `ModuleManager`
   - Each builder (`LogBuilder`, `DatabaseSlowStatementBuilder`, `SampledTraceBuilder`, `EnvoyAccessLogBuilder`) resolves its own services and caches them in static fields (set-once pattern)
   - `RecordSinkListener` simplified: no more `NamingControl`, `searchableTagKeys`, or `instanceof` check
   - v1 (Groovy) code is untouched — backward-compatible `NamingControl` constructors retained
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
   - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor LALOutputBuilder.init() to take ModuleManager instead of NamingControl [skywalking]

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng merged PR #13741:
URL: https://github.com/apache/skywalking/pull/13741


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org