You are viewing a plain text version of this content. The canonical link for it is here.
Posted to xap-commits@incubator.apache.org by mt...@apache.org on 2006/08/23 02:07:23 UTC

svn commit: r433836 - in /incubator/xap/trunk/src/xap/bridges/dojo: DojoButtonBridge.js DojoWidgetBridge.js

Author: mturyn
Date: Tue Aug 22 19:07:23 2006
New Revision: 433836

URL: http://svn.apache.org/viewvc?rev=433836&view=rev
Log:
Attribute setting now firmly fixed in bridges as much as possible; next will need to move attribute mappers (property name to function) from the instances to the classes---saves space, but makes inheritance trickier.....

Modified:
    incubator/xap/trunk/src/xap/bridges/dojo/DojoButtonBridge.js
    incubator/xap/trunk/src/xap/bridges/dojo/DojoWidgetBridge.js

Modified: incubator/xap/trunk/src/xap/bridges/dojo/DojoButtonBridge.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/src/xap/bridges/dojo/DojoButtonBridge.js?rev=433836&r1=433835&r2=433836&view=diff
==============================================================================
--- incubator/xap/trunk/src/xap/bridges/dojo/DojoButtonBridge.js (original)
+++ incubator/xap/trunk/src/xap/bridges/dojo/DojoButtonBridge.js Tue Aug 22 19:07:23 2006
@@ -147,7 +147,7 @@
  }
  
 
-xap.bridges.dojo.DojoButtonBridge.prototype.setTitleAttribute = function(name,value){
+xap.bridges.dojo.DojoButtonBridge.prototype.setTextAttribute = function(value){
 	xap.bridges.dojo.DojoButtonBridge.changeCaption(this.getPeer(),value) ;
 }
 
@@ -158,7 +158,7 @@
 	if( !this._allowedAttributes ){
 	// Memoise
 		this._allowedAttributes = this.superclass.getAllowedAttributes() ;
-		this._allowedAttributes.title = null ;
+		this._allowedAttributes.text = null ;
 	}
 	return this._allowedAttributes ;
 }	

Modified: incubator/xap/trunk/src/xap/bridges/dojo/DojoWidgetBridge.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/src/xap/bridges/dojo/DojoWidgetBridge.js?rev=433836&r1=433835&r2=433836&view=diff
==============================================================================
--- incubator/xap/trunk/src/xap/bridges/dojo/DojoWidgetBridge.js (original)
+++ incubator/xap/trunk/src/xap/bridges/dojo/DojoWidgetBridge.js Tue Aug 22 19:07:23 2006
@@ -336,30 +336,30 @@
 }
 
 
-xap.bridges.dojo.DojoWidgetBridge.prototype.setXAttribute = function(name,value){
+xap.bridges.dojo.DojoWidgetBridge.prototype.setXAttribute = function(value){
 	// Mediocre behaviour, can improve in subclasses as needed
 	this.getPeer().domNode.style.left = value ;
 }
-xap.bridges.dojo.DojoWidgetBridge.prototype.setYAttribute = function(name,value){
+xap.bridges.dojo.DojoWidgetBridge.prototype.setYAttribute = function(value){
 	// Mediocre behaviour, can improve in subclasses as needed
 	this.getPeer().domNode.style.top = value ;
 }
 
-xap.bridges.dojo.DojoWidgetBridge.prototype.setWidthAttribute = function(name,value){
+xap.bridges.dojo.DojoWidgetBridge.prototype.setWidthAttribute = function(value){
 	// Mediocre behaviour, can improve in subclasses as needed
 	this.getPeer().domNode.style.width = value ;
 }
-xap.bridges.dojo.DojoWidgetBridge.prototype.setHeightAttribute = function(name,value){
+xap.bridges.dojo.DojoWidgetBridge.prototype.setHeightAttribute = function(value){
 	// Mediocre behaviour, can improve in subclasses as needed
 	this.getPeer().domNode.style.height = value ;
 }
 
-xap.bridges.dojo.DojoWidgetBridge.prototype.setColorAttribute = function(name,value){
+xap.bridges.dojo.DojoWidgetBridge.prototype.setColorAttribute = function(value){
 	// Mediocre behaviour, can improve in subclasses as needed
 	this.getPeer().domNode.style.color = value ;
 }
 
-xap.bridges.dojo.DojoWidgetBridge.prototype.setBackgroundColorAttribute = function(name,value){
+xap.bridges.dojo.DojoWidgetBridge.prototype.setBackgroundColorAttribute = function(value){
 	// Mediocre behaviour, can improve in subclasses as needed
 	this.getPeer().domNode.style.backgroundColor = value ;
 }