You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by manjuapu <gi...@git.apache.org> on 2017/09/23 01:04:51 UTC

[GitHub] kafka-site pull request #85: Adding New York logo to powered-by and Streams ...

GitHub user manjuapu opened a pull request:

    https://github.com/apache/kafka-site/pull/85

    Adding New York logo to powered-by and Streams page

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manjuapu/kafka-site asf-site

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka-site/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #85
    
----
commit c2d9655875958e382849fb700a82510b8f44ee97
Author: Manjula K <ma...@kafka-summit.org>
Date:   2017-09-22T16:36:36Z

    Adding LINE logo to Streams page

commit 1b2c0e447d8ed19183c8c0643220688d311fdb54
Author: Manjula K <ma...@kafka-summit.org>
Date:   2017-09-23T01:03:18Z

    Adding New York logo to powered-by and Streams page

----


---

[GitHub] kafka-site issue #85: Adding New York logo to powered-by and Streams page

Posted by manjuapu <gi...@git.apache.org>.
Github user manjuapu commented on the issue:

    https://github.com/apache/kafka-site/pull/85
  
    @guozhangwang Please review.


---

[GitHub] kafka-site pull request #85: Adding New York logo to powered-by and Streams ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka-site/pull/85


---

[GitHub] kafka-site issue #85: Adding New York logo to powered-by and Streams page

Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on the issue:

    https://github.com/apache/kafka-site/pull/85
  
    Merged to trunk with some minor tweaks.


---

[GitHub] kafka-site pull request #85: Adding New York logo to powered-by and Streams ...

Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on a diff in the pull request:

    https://github.com/apache/kafka-site/pull/85#discussion_r140623385
  
    --- Diff: 0110/streams/index.html ---
    @@ -201,39 +201,41 @@ <h3 style="max-width: 75rem;">The easiest way to write mission-critical real-tim
                 </pre>
             </div>
         </div>
    -    <h3 class="customer-title">See how Kafka Streams is being used</h3>
    +   <h3 class="customer-title">See how Kafka Streams is being used</h3>
         <div class="customer__cards">
              <div class="customer__card">
                  <div class="customer__card__icon">
    +            <img src="/{{version}}/images/icons/NYT.jpg" style="max-width:35%">
    +          </div>  
    +          <span class="customer__card__label">The New York Times uses Kafka and the Kafka Streams API to store and distribute, in real-time, published content to the various applications and systems that make it available to the readers.</span>
    --- End diff --
    
    nit: ..Apache Kafka and Kafka Streams...


---

[GitHub] kafka-site pull request #85: Adding New York logo to powered-by and Streams ...

Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on a diff in the pull request:

    https://github.com/apache/kafka-site/pull/85#discussion_r140623361
  
    --- Diff: 0110/streams/index.html ---
    @@ -201,39 +201,41 @@ <h3 style="max-width: 75rem;">The easiest way to write mission-critical real-tim
                 </pre>
             </div>
         </div>
    -    <h3 class="customer-title">See how Kafka Streams is being used</h3>
    +   <h3 class="customer-title">See how Kafka Streams is being used</h3>
    --- End diff --
    
    This indentation seems unintentional. 


---

[GitHub] kafka-site issue #85: Adding New York logo to powered-by and Streams page

Posted by manjuapu <gi...@git.apache.org>.
Github user manjuapu commented on the issue:

    https://github.com/apache/kafka-site/pull/85
  
    @guozhangwang Added Apache word


---