You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by ga...@gmail.com on 2010/06/17 01:59:17 UTC

Adding host and proxy path for Proxy Uris. (issue1697041)

Reviewers: johnfargo, zhoresh, shindig.remailer_gmail.com,  
dev-remailer_shindig.apache.org,

Message:
Closing issue as this has been submitted in
http://codereview.appspot.com/1686043/show

Description:
1) Adding host and path for proxyied uris without which proxy and concat
servlets dont seem to work for default container.
2) Separating out the uri for the default shindig test instance into 2
configs
a) defaultShindigTestHost: "http://localhost:9003",
b) defaultShindigProxyConcatAuthority: "localhost:9003",
with the latter one being the one that gets passed to the call to
Uribuilder.setAuthority()

Without this, we were passing on "http://localhost:9003" to setAuthority
which is bad.

Please review this at http://codereview.appspot.com/1697041/show

Affected files:
   M     config/container.js


Index: config/container.js
===================================================================
--- config/container.js	(revision 953578)
+++ config/container.js	(working copy)
@@ -91,8 +91,12 @@
  //"gadgets.securityTokenType" : "secure",
  //"gadgets.securityTokenKeyFile" : "/path/to/key/file.txt",

+// URI for the default shindig test instance.
  "defaultShindigTestHost": "http://localhost:9003",

+// Authority (host:port without scheme) for the proxy and concat servlets.
+"defaultShindigProxyConcatAuthority": "localhost:9003",
+
  // Default Uri config: these must be overridden - specified here for  
testing purposes
  "gadgets.uri.iframe.unlockedDomain": "${Cur['defaultShindigTestHost']}",
  "gadgets.uri.iframe.lockedDomainSuffix": "${Cur['defaultShindigTestHost']}",
@@ -102,9 +106,14 @@
  "gadgets.uri.js.path": "/gadgets/js",

  // Default concat Uri config; used for testing.
-"gadgets.uri.concat.host" : "${Cur['defaultShindigTestHost']}",
+"gadgets.uri.concat.host" : "${Cur['defaultShindigProxyConcatAuthority']}",
  "gadgets.uri.concat.path" : "/gadgets/concat",
+"gadgets.uri.concat.js.splitToken" : "false",

+// Default proxy Uri config; used for testing.
+"gadgets.uri.proxy.host" : "${Cur['defaultShindigProxyConcatAuthority']}",
+"gadgets.uri.proxy.path" : "/gadgets/proxy",
+
  // This config data will be passed down to javascript. Please
  // configure your object using the feature name rather than
  // the javascript name.