You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (Jira)" <ji...@apache.org> on 2021/06/06 11:04:00 UTC
[jira] [Commented] (SLING-10451) ArtifactManagerConfig leaves empty
"slingfeature" folders in the java tmp directory
[ https://issues.apache.org/jira/browse/SLING-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358088#comment-17358088 ]
Carsten Ziegeler commented on SLING-10451:
------------------------------------------
While I agree with the description I think the PR is too agressive - we have to go with the originator principle here: if the ArtifactManagerConfig is used its own temp directory, then it *might* be ok to remove it afterwards. If setCacheDirectory is called with a custom directory then that directory must not be removed.
> ArtifactManagerConfig leaves empty "slingfeature" folders in the java tmp directory
> -----------------------------------------------------------------------------------
>
> Key: SLING-10451
> URL: https://issues.apache.org/jira/browse/SLING-10451
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
> Reporter: Konrad Windszus
> Priority: Major
> Fix For: Feature Model 1.2.24
>
>
> With every run of {{FeatureBuilder.assemble}} empty folders starting with prefix {{slingfeature}} and followed by a random number are left in the java tmp folder. Those should be properly cleaned up. The creation happens in https://github.com/apache/sling-org-apache-sling-feature/blob/afbad06b30ad1ff81ce25d8a27d3dcd2abbfc035/src/main/java/org/apache/sling/feature/io/artifacts/ArtifactManagerConfig.java#L66.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)