[GitHub] [commons-lang] aherbert commented on pull request #1070: LANG-1644

["aherbert (via GitHub)" <gi...@apache.org>]

aherbert commented on PR #1070:
URL: https://github.com/apache/commons-lang/pull/1070#issuecomment-1632582115

   Note that the PR author is a new contributor working on existing tickets in Commons that they did not create.
   
   This PR is related to a ticket created by Arturo Bernal. In most cases of such tickets there is a corresponding PR with a discussion on why the original contribution was rejected. These should be considered when updating a contribution.
   
   Please see my comments on this functionality in PR #727. I think the method has no use cases, i.e. why detect if a number is a hexidecimal if you are not then going to create one using the available parsing methods in NumberUtils. This PR currently only handles unsigned integer numbers. IMO it should be fixed to be compatible with NumberUtils such that it is:
   
   ```
   "a subset of isCreateable that will return true only if the Number created by createNumber is a mathematical integer"
   ```
   
   Note also the recently merged #1069 by @orionlibs adds functionality that was never merged from another Arturo ticket #729. The reason is not in the PR (which was recently closed probably due to stagnation) and the corresponding Jira ticket 1647 was deleted. The mailing list had some discussion on the merits of the method and it was inconclusive. I would be cautious about working on long standing tickets without first viewing associated PRs. In most cases the tickets are left open but should have been marked with a reason for the PR rejection if applicable so it can be addressed by further work.
   
   Note that this is not a rejection of the PR or new contributions but a wish to see the full history of the functionality considered so we can merge code with full consideration of the use cases.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org