You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Nettleton <rn...@hortonworks.com> on 2014/10/21 18:15:23 UTC
Review Request 26981: Added export handling for new Hive/Zookeeper
config property in HDP 2.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26981/
-----------------------------------------------------------
Review request for Ambari, John Speidel and Nate Cole.
Repository: ambari
Description
-------
This patch implements a fix for Ambari Bug AMBARI-7869.
The following hive-site.xml property:
hive.cluster.delegation.token.store.zookeeper.connectString
has recently been added to the HDP 2.2 stack definition.
Currently, if an export is attempted on an HDP 2.2 cluster that includes
Hive, the export of this property will include hostname information.
This patch addresses this problem by registering the relevant
PropertyUpdater implementation for this property, to ensure
that the export process removes hostname information, and instead
refers to the host group that includes the Zookeeper server.
This patch also adds a new assertion to an existing unit test
to verify this change.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 0b58c8d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java a57bacb
Diff: https://reviews.apache.org/r/26981/diff/
Testing
-------
1. Ran unit tests with change applied (in trunk and 1.7), and all unit tests are passing.
2. Manually verified the fix against trunk.
3. Manually verified the fix against 1.7.0.
Thanks,
Robert Nettleton
Re: Review Request 26981: Added export handling for new Hive/Zookeeper
config property in HDP 2.2
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26981/#review57835
-----------------------------------------------------------
Merged to 1.7.0 and trunk.
All unit tests pass in both branches.
Results :
Tests run: 2118, Failures: 0, Errors: 0, Skipped: 17
...
Total run:667
Total errors:0
Total failures:0
- John Speidel
On Oct. 21, 2014, 4:15 p.m., Robert Nettleton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26981/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2014, 4:15 p.m.)
>
>
> Review request for Ambari, John Speidel and Nate Cole.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This patch implements a fix for Ambari Bug AMBARI-7869.
>
> The following hive-site.xml property:
>
> hive.cluster.delegation.token.store.zookeeper.connectString
>
> has recently been added to the HDP 2.2 stack definition.
>
> Currently, if an export is attempted on an HDP 2.2 cluster that includes
> Hive, the export of this property will include hostname information.
>
> This patch addresses this problem by registering the relevant
> PropertyUpdater implementation for this property, to ensure
> that the export process removes hostname information, and instead
> refers to the host group that includes the Zookeeper server.
>
> This patch also adds a new assertion to an existing unit test
> to verify this change.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 0b58c8d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java a57bacb
>
> Diff: https://reviews.apache.org/r/26981/diff/
>
>
> Testing
> -------
>
> 1. Ran unit tests with change applied (in trunk and 1.7), and all unit tests are passing.
> 2. Manually verified the fix against trunk.
> 3. Manually verified the fix against 1.7.0.
>
>
> Thanks,
>
> Robert Nettleton
>
>
Re: Review Request 26981: Added export handling for new Hive/Zookeeper
config property in HDP 2.2
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26981/#review58625
-----------------------------------------------------------
Bob, if this has been completed please mark this review as submitted.
- Nate Cole
On Oct. 21, 2014, 12:15 p.m., Robert Nettleton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26981/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2014, 12:15 p.m.)
>
>
> Review request for Ambari, John Speidel and Nate Cole.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This patch implements a fix for Ambari Bug AMBARI-7869.
>
> The following hive-site.xml property:
>
> hive.cluster.delegation.token.store.zookeeper.connectString
>
> has recently been added to the HDP 2.2 stack definition.
>
> Currently, if an export is attempted on an HDP 2.2 cluster that includes
> Hive, the export of this property will include hostname information.
>
> This patch addresses this problem by registering the relevant
> PropertyUpdater implementation for this property, to ensure
> that the export process removes hostname information, and instead
> refers to the host group that includes the Zookeeper server.
>
> This patch also adds a new assertion to an existing unit test
> to verify this change.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 0b58c8d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java a57bacb
>
> Diff: https://reviews.apache.org/r/26981/diff/
>
>
> Testing
> -------
>
> 1. Ran unit tests with change applied (in trunk and 1.7), and all unit tests are passing.
> 2. Manually verified the fix against trunk.
> 3. Manually verified the fix against 1.7.0.
>
>
> Thanks,
>
> Robert Nettleton
>
>
Re: Review Request 26981: Added export handling for new Hive/Zookeeper
config property in HDP 2.2
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26981/#review57642
-----------------------------------------------------------
Ship it!
Ship It!
- John Speidel
On Oct. 21, 2014, 4:15 p.m., Robert Nettleton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26981/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2014, 4:15 p.m.)
>
>
> Review request for Ambari, John Speidel and Nate Cole.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This patch implements a fix for Ambari Bug AMBARI-7869.
>
> The following hive-site.xml property:
>
> hive.cluster.delegation.token.store.zookeeper.connectString
>
> has recently been added to the HDP 2.2 stack definition.
>
> Currently, if an export is attempted on an HDP 2.2 cluster that includes
> Hive, the export of this property will include hostname information.
>
> This patch addresses this problem by registering the relevant
> PropertyUpdater implementation for this property, to ensure
> that the export process removes hostname information, and instead
> refers to the host group that includes the Zookeeper server.
>
> This patch also adds a new assertion to an existing unit test
> to verify this change.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 0b58c8d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java a57bacb
>
> Diff: https://reviews.apache.org/r/26981/diff/
>
>
> Testing
> -------
>
> 1. Ran unit tests with change applied (in trunk and 1.7), and all unit tests are passing.
> 2. Manually verified the fix against trunk.
> 3. Manually verified the fix against 1.7.0.
>
>
> Thanks,
>
> Robert Nettleton
>
>
Re: Review Request 26981: Added export handling for new Hive/Zookeeper
config property in HDP 2.2
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26981/#review57649
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Oct. 21, 2014, 12:15 p.m., Robert Nettleton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26981/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2014, 12:15 p.m.)
>
>
> Review request for Ambari, John Speidel and Nate Cole.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This patch implements a fix for Ambari Bug AMBARI-7869.
>
> The following hive-site.xml property:
>
> hive.cluster.delegation.token.store.zookeeper.connectString
>
> has recently been added to the HDP 2.2 stack definition.
>
> Currently, if an export is attempted on an HDP 2.2 cluster that includes
> Hive, the export of this property will include hostname information.
>
> This patch addresses this problem by registering the relevant
> PropertyUpdater implementation for this property, to ensure
> that the export process removes hostname information, and instead
> refers to the host group that includes the Zookeeper server.
>
> This patch also adds a new assertion to an existing unit test
> to verify this change.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 0b58c8d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java a57bacb
>
> Diff: https://reviews.apache.org/r/26981/diff/
>
>
> Testing
> -------
>
> 1. Ran unit tests with change applied (in trunk and 1.7), and all unit tests are passing.
> 2. Manually verified the fix against trunk.
> 3. Manually verified the fix against 1.7.0.
>
>
> Thanks,
>
> Robert Nettleton
>
>