You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2025/09/04 01:01:56 UTC
[PR] Fix regression in MnemonicEditor#setValue [netbeans]
mbien opened a new pull request, #8787:
URL: https://github.com/apache/netbeans/pull/8787
regression since https://github.com/apache/netbeans/pull/8385
fixes #8780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix regression in MnemonicEditor#setValue [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8787:
URL: https://github.com/apache/netbeans/pull/8787#issuecomment-3251300371
I think I remember what happened there, the PR wasn't meant to be merged that early since while updating the very last method in the patch, I thought that this would look much more straight forward with instanceof pattern chains (thats why i probably started removing the return statements). But bumping the module lang version didn't work, so I opened https://github.com/apache/netbeans/pull/8387 and didn't change it back.
I must have forgotten about it and the PR got merged by accident most likely (https://github.com/apache/netbeans/pull/8385#issuecomment-2775710760)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix regression in MnemonicEditor#setValue [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8787:
URL: https://github.com/apache/netbeans/pull/8787#issuecomment-3263441691
fix was tested at https://github.com/apache/netbeans/issues/8780#issuecomment-3253884336, planning to merge it soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix regression in MnemonicEditor#setValue [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #8787:
URL: https://github.com/apache/netbeans/pull/8787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists