[GitHub] [pulsar] merlimat commented on a change in pull request #4252: [Issue 4251][Schemas] add schema parsing verification before update

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #4252: [Issue 4251][Schemas] add schema parsing verification before update
URL: https://github.com/apache/pulsar/pull/4252#discussion_r282604595
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/AvroSchemaBasedCompatibilityCheck.java
 ##########
 @@ -22,27 +22,44 @@
 
 import java.util.Arrays;
 import org.apache.avro.Schema;
+import org.apache.avro.SchemaParseException;
 import org.apache.avro.SchemaValidationException;
 import org.apache.avro.SchemaValidator;
 import org.apache.avro.SchemaValidatorBuilder;
 import org.apache.pulsar.common.schema.SchemaData;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * The abstract implementation of {@link SchemaCompatibilityCheck} using Avro Schema.
  */
 abstract class AvroSchemaBasedCompatibilityCheck implements SchemaCompatibilityCheck {
+    Logger log = LoggerFactory.getLogger(SchemaRegistryService.class);
 
 Review comment:
   `private static final Logger ...` or just add `@Slf4j` annotation to the class

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services