[GitHub] [zookeeper] jeffrey-xiao opened a new pull request, #1930: ZOOKEEPER-4394

[GitBox <gi...@apache.org>]

jeffrey-xiao opened a new pull request, #1930:
URL: https://github.com/apache/zookeeper/pull/1930

   This PR resolves ZOOKEEPER-4394.
   
   The first commit adds a failing test that demonstrates that a leader sending an outstanding proposal during a DIFF will cause an NPE if the commit to the proposal comes before the UPTODATE.
   
   The second commit fixes the failing test and addresses the problem by splitting `packetsNotCommitted` to a separate field called `packetsNotLogged`. The former keeps track of packets that needs to be committed while the latter keeps track of packets that needs to be logged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] sonatype-lift[bot] commented on pull request #1930: ZOOKEEPER-4394

[GitBox <gi...@apache.org>]

sonatype-lift[bot] commented on PR #1930:
URL: https://github.com/apache/zookeeper/pull/1930#issuecomment-1263687608

   :warning: **52 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/zookeeper/01GE7DYR0CB7G8XC49FBYF0NH0?tab=technical-debt&utm_source=github.com&utm_campaign=lift-comment&utm_content=apache\%20zookeeper) for more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org