You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/22 19:08:32 UTC

[GitHub] [airflow] potiuk opened a new pull request #8976: You can push with Breeze as separate command and to cache

potiuk opened a new pull request #8976:
URL: https://github.com/apache/airflow/pull/8976


   Breeze had --push-images switch to also push images to repo
   but it was often needed to build and push images separately.
   
   We have now a possibility to push an already built image with
   separate push-image command instead and also you can choose
   to push to cache registry in GitHub rather than to DockerHub
   with --registry-cache switch.
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Target Github ISSUE in description if exists
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #8976: You can push with Breeze as separate command and to cache

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #8976:
URL: https://github.com/apache/airflow/pull/8976#issuecomment-633130178


   I thin this one is good to go - and it helps a lot with dealing with cache/pushing images manualy to cache as well if needed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #8976: You can push with Breeze as separate command and to cache

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #8976:
URL: https://github.com/apache/airflow/pull/8976#issuecomment-633957800


   I'd love to merge it as I am closed to start working back on the prod image.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #8976: You can push with Breeze as separate command and to cache

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #8976:
URL: https://github.com/apache/airflow/pull/8976


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #8976: You can push with Breeze as separate command and to cache

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #8976:
URL: https://github.com/apache/airflow/pull/8976#issuecomment-634859654


   @ashb @dimberman @kaxil @mik-laj -> that one wil make it easier to iterate on CI/Prod images - as I will be switching back to it, It would be useful to merge it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org