[GitHub] [cassandra] ekaterinadimitrova2 commented on a diff in pull request #1940: [CASSANDRA-17950] Enable dtest-offheap in CircleCI

[GitBox <gi...@apache.org>]

ekaterinadimitrova2 commented on code in PR #1940:
URL: https://github.com/apache/cassandra/pull/1940#discussion_r1002230952


##########
.circleci/config-2_1.yml:
##########
@@ -655,6 +662,21 @@ jobs:
           stop_on_failure: ${REPEATED_TESTS_STOP_ON_FAILURE}
           count: ${REPEATED_UPGRADE_DTESTS_COUNT}
 
+  j8_offheap_dtest:
+    <<: *j8_par_executor
+    steps:
+      - attach_workspace:
+          at: /home/cassandra
+      - log_environment
+      - clone_dtest
+      - create_venv
+      - create_dtest_containers:
+          file_tag: j8_with_vnodes

Review Comment:
   Shouldn't this be something like `j8_offheap_dtest` or so?



##########
.circleci/config-2_1.yml:
##########
@@ -655,6 +662,21 @@ jobs:
           stop_on_failure: ${REPEATED_TESTS_STOP_ON_FAILURE}
           count: ${REPEATED_UPGRADE_DTESTS_COUNT}
 
+  j8_offheap_dtest:
+    <<: *j8_par_executor
+    steps:
+      - attach_workspace:
+          at: /home/cassandra
+      - log_environment
+      - clone_dtest
+      - create_venv
+      - create_dtest_containers:
+          file_tag: j8_with_vnodes
+          run_dtests_extra_args: "--use-vnodes --use-off-heap-memtables --skip-resource-intensive-tests --pytest-options '-k not cql'"

Review Comment:
   To be honest, I am not sure where this came from - `--pytest-options '-k not cql'"`



##########
.circleci/config-2_1.yml:
##########
@@ -655,6 +662,21 @@ jobs:
           stop_on_failure: ${REPEATED_TESTS_STOP_ON_FAILURE}
           count: ${REPEATED_UPGRADE_DTESTS_COUNT}
 
+  j8_offheap_dtest:
+    <<: *j8_par_executor
+    steps:
+      - attach_workspace:
+          at: /home/cassandra
+      - log_environment
+      - clone_dtest
+      - create_venv
+      - create_dtest_containers:
+          file_tag: j8_with_vnodes
+          run_dtests_extra_args: "--use-vnodes --use-off-heap-memtables --skip-resource-intensive-tests --pytest-options '-k not cql'"
+      - run_dtests:
+          file_tag: j8_with_vnodes
+          pytest_extra_args: '--use-vnodes --num-tokens=16 --use-off-heap-memtables --skip-resource-intensive-tests'

Review Comment:
   verified with this one https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L84



##########
.circleci/config-2_1.yml:
##########
@@ -391,6 +391,13 @@ pre-commit_jobs: &pre-commit_jobs
     - j8_repeated_ant_test:
         requires:
           - build
+    # Java 8 off-heap tests
+    - start_offheap_dtest:
+        type: approval
+    - j8_offheap_dtest:
+        requires:
+          - start_offheap_dtest
+          - build

Review Comment:
   We will need also repeat jobs similar to other jobs in order to fight any potential flakiness :-) Something similar this : https://github.com/apache/cassandra/pull/1940/commits/97ebcb5fe6ae290da0a24228177df8e47aefbaba



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org