[GitHub] mistercrunch commented on a change in pull request #4755: Pass granularity from backend to frontend as ISO duration

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #4755: Pass granularity from backend to frontend as ISO duration
URL: https://github.com/apache/incubator-superset/pull/4755#discussion_r179266163
 
 

 ##########
 File path: superset/assets/javascripts/explore/stores/controls.jsx
 ##########
 @@ -699,21 +699,21 @@ export const controls = {
     freeForm: true,
     label: t('Time Granularity'),
     default: 'one day',
-    choices: formatSelectOptions([
-      'all',
-      '5 seconds',
-      '30 seconds',
-      '1 minute',
-      '5 minutes',
-      '1 hour',
-      '6 hour',
-      '1 day',
-      '7 days',
-      'week',
-      'week_starting_sunday',
-      'week_ending_saturday',
-      'month',
-    ]),
+    choices: [
+      [null, 'all'],
+      ['PT5S', '5 seconds'],
 
 Review comment:
   If a chart has been saved with a string say `5 seconds` as a value, did you confirm that this load up ok in here as a "free form" value? From my understanding it should.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services