You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/01/27 18:13:27 UTC
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8311: fix run ltp_interfaces_sched_setscheduler_17_1 fail
xiaoxiang781216 opened a new pull request, #8311:
URL: https://github.com/apache/nuttx/pull/8311
## Summary
The policy has changed when sched_setscheduler called invalid args.
## Impact
Minor
## Testing
ltp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #8311: fix run ltp_interfaces_sched_setscheduler_17_1 fail
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #8311:
URL: https://github.com/apache/nuttx/pull/8311#discussion_r1089412551
##########
sched/sched/sched_setscheduler.c:
##########
@@ -96,6 +96,14 @@ int nxsched_set_scheduler(pid_t pid, int policy,
return -EINVAL;
}
+ /* Verify that the requested priority is in the valid range */
+
+ if (param->sched_priority < SCHED_PRIORITY_MIN ||
+ param->sched_priority > SCHED_PRIORITY_MAX)
Review Comment:
```suggestion
param->sched_priority > SCHED_PRIORITY_MAX)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko merged pull request #8311: fix run ltp_interfaces_sched_setscheduler_17_1 fail
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko merged PR #8311:
URL: https://github.com/apache/nuttx/pull/8311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8311: fix run ltp_interfaces_sched_setscheduler_17_1 fail
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8311:
URL: https://github.com/apache/nuttx/pull/8311#discussion_r1089422245
##########
sched/sched/sched_setscheduler.c:
##########
@@ -96,6 +96,14 @@ int nxsched_set_scheduler(pid_t pid, int policy,
return -EINVAL;
}
+ /* Verify that the requested priority is in the valid range */
+
+ if (param->sched_priority < SCHED_PRIORITY_MIN ||
+ param->sched_priority > SCHED_PRIORITY_MAX)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org