You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2017/02/27 18:13:06 UTC
[GitHub] cordova-windows pull request #228: CB-12499 UWP: Dependent external librarie...
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-windows/pull/228
CB-12499 UWP: Dependent external libraries specified as resource-file\u2026
\u2026 not being referenced in Release mode
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Windows
### What does this PR do?
Adds Default.rd.xml to Windows 10 project template making an app (and plugins) metadata to be available for reflection at runtime
### What testing has been done on this change?
npm tests, WACK tests
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-windows CB-12499
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/228.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #228
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #228: CB-12499 UWP: Dependent external libraries speci...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/228
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request #228: CB-12499 UWP: Dependent external librarie...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #228: CB-12499 UWP: Dependent external libraries speci...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/228
# [Codecov](https://codecov.io/gh/apache/cordova-windows/pull/228?src=pr&el=h1) Report
> Merging [#228](https://codecov.io/gh/apache/cordova-windows/pull/228?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-windows/commit/a4ab7ccb59516a3d3d937b7b708d9bd4cac80159?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #228 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 16 16
Lines 2222 2222
Branches 439 439
=======================================
Hits 1709 1709
Misses 513 513
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-windows/pull/228?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-windows/pull/228?src=pr&el=footer). Last update [a4ab7cc...d5ddcb4](https://codecov.io/gh/apache/cordova-windows/compare/a4ab7ccb59516a3d3d937b7b708d9bd4cac80159...d5ddcb4c4f546d2aa7707b57b26c5143ff42c91f?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org