You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Cliff Woolley <cl...@yahoo.com> on 2001/08/23 22:42:57 UTC
Re: cvs commit: httpd-2.0/modules/ssl mod_ssl.h ssl_engine_config.c
ssl_engine_init.c
On 23 Aug 2001 wrowe@apache.org wrote:
> wrowe 01/08/23 12:42:44
>
> Modified: modules/ssl mod_ssl.h ssl_engine_config.c ssl_engine_init.c
> Log:
> Add some appropriate constness to the config
>
> Revision Changes Path
> 1.30 +17 -17 httpd-2.0/modules/ssl/mod_ssl.h
...
> - char *szPassPhraseDialogPath;
> + const char *szPassPhraseDialogPath;
This change is causing a warning about loss of constness now at
ssl_engine_pphrase.c:535 because szPassPhraseDialogPath is passed to
ap_strchr() which does not qualify its argument as const. Should this
line be backed down to char * or does something else need to be done?
--Cliff
--------------------------------------------------------------
Cliff Woolley
cliffwoolley@yahoo.com
Charlottesville, VA
Re: cvs commit: httpd-2.0/modules/ssl mod_ssl.h ssl_engine_config.c ssl_engine_init.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
From: "Cliff Woolley" <cl...@yahoo.com>
Sent: Thursday, August 23, 2001 3:42 PM
> On 23 Aug 2001 wrowe@apache.org wrote:
>
> > wrowe 01/08/23 12:42:44
> >
> > Modified: modules/ssl mod_ssl.h ssl_engine_config.c ssl_engine_init.c
> > Log:
> > Add some appropriate constness to the config
> >
> > Revision Changes Path
> > 1.30 +17 -17 httpd-2.0/modules/ssl/mod_ssl.h
> ...
> > - char *szPassPhraseDialogPath;
> > + const char *szPassPhraseDialogPath;
>
> This change is causing a warning about loss of constness now at
> ssl_engine_pphrase.c:535 because szPassPhraseDialogPath is passed to
> ap_strchr() which does not qualify its argument as const. Should this
> line be backed down to char * or does something else need to be done?
Are we allowed to modify the conf after we create it? If not, any side effects
of properly typing the config need to be dealt with.
Re: cvs commit: httpd-2.0/modules/ssl mod_ssl.h ssl_engine_config.c ssl_engine_init.c
Posted by Ryan Bloom <rb...@covalent.net>.
just use ap_strchr_c instead of ap_strchr.
Ryan
On Thursday 23 August 2001 13:42, Cliff Woolley wrote:
> On 23 Aug 2001 wrowe@apache.org wrote:
> > wrowe 01/08/23 12:42:44
> >
> > Modified: modules/ssl mod_ssl.h ssl_engine_config.c
> > ssl_engine_init.c Log:
> > Add some appropriate constness to the config
> >
> > Revision Changes Path
> > 1.30 +17 -17 httpd-2.0/modules/ssl/mod_ssl.h
>
> ...
>
> > - char *szPassPhraseDialogPath;
> > + const char *szPassPhraseDialogPath;
>
> This change is causing a warning about loss of constness now at
> ssl_engine_pphrase.c:535 because szPassPhraseDialogPath is passed to
> ap_strchr() which does not qualify its argument as const. Should this
> line be backed down to char * or does something else need to be done?
>
> --Cliff
>
> --------------------------------------------------------------
> Cliff Woolley
> cliffwoolley@yahoo.com
> Charlottesville, VA
--
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------