APR_MMAP

[David Reid <ab...@dial.pipex.com>]

I'll commit the apr_mmap.h file that I forgot last night (would have done it
earlier but was grabbed for a Marseille).  A couple of questions that I have
no real preference over...

In apr_send_mmap do we want to
1) simply have it send the entire file every time it's called
2) be able to specify how much of a file should be sent

I guess it boils down to how we're goign to be using the call in the apache
code.  The same question applies to the apr_read_mmap.

I'm asking before I code so as to avoid changing everything later (just call
me lazy :-))

david

Re: APR_MMAP

[David Reid <ab...@dial.pipex.com>]

Dean,

if we don't need ap_mmap_send then they needn't be written!  i'm
easy...(less effort on my part :-))

d.
----- Original Message -----
From: Dean Gaudet <dg...@arctic.org>
To: <ne...@apache.org>
Sent: 28 October 1999 19:13
Subject: Re: APR_MMAP


> hrm, i haven't had a chance to look at what david did... but all i was
> really expecting was a mmap interface in APR which mapped stuff into
> memory, and http_core would continue to have some variant of send_mmap().
> it just needs a portable way to get bits of the file mapped into memory...
>
> i see david is putting some of the send stuff into APR... that feels
> wrong.  for the reason greg is bringing up, and other similar ones.
> (consider an IMAP server which wants to MMAP a file, but it needs to do
> CRLF conversion before sending... or something sending EBCDIC...)
>
> Dean
>
> On Thu, 21 Oct 1999, Greg Stein wrote:
>
> > Doesn't it have to be able to send sub-ranges, in case the client asked
> > for ranges?
> >
> > -g
> >
> > On Thu, 21 Oct 1999, David Reid wrote:
> > > I'll commit the apr_mmap.h file that I forgot last night (would have
done it
> > > earlier but was grabbed for a Marseille).  A couple of questions that
I have
> > > no real preference over...
> > >
> > > In apr_send_mmap do we want to
> > > 1) simply have it send the entire file every time it's called
> > > 2) be able to specify how much of a file should be sent
> > >
> > > I guess it boils down to how we're goign to be using the call in the
apache
> > > code.  The same question applies to the apr_read_mmap.
> > >
> > > I'm asking before I code so as to avoid changing everything later
(just call
> > > me lazy :-))
> > >
> > > david
> > >
> >
> > --
> > Greg Stein, http://www.lyra.org/
> >
> >
>

Re: APR_MMAP

[Dean Gaudet <dg...@arctic.org>]

hrm, i haven't had a chance to look at what david did... but all i was
really expecting was a mmap interface in APR which mapped stuff into
memory, and http_core would continue to have some variant of send_mmap().  
it just needs a portable way to get bits of the file mapped into memory...

i see david is putting some of the send stuff into APR... that feels
wrong.  for the reason greg is bringing up, and other similar ones.  
(consider an IMAP server which wants to MMAP a file, but it needs to do
CRLF conversion before sending... or something sending EBCDIC...)

Dean

On Thu, 21 Oct 1999, Greg Stein wrote:

> Doesn't it have to be able to send sub-ranges, in case the client asked
> for ranges?
> 
> -g
> 
> On Thu, 21 Oct 1999, David Reid wrote:
> > I'll commit the apr_mmap.h file that I forgot last night (would have done it
> > earlier but was grabbed for a Marseille).  A couple of questions that I have
> > no real preference over...
> > 
> > In apr_send_mmap do we want to
> > 1) simply have it send the entire file every time it's called
> > 2) be able to specify how much of a file should be sent
> > 
> > I guess it boils down to how we're goign to be using the call in the apache
> > code.  The same question applies to the apr_read_mmap.
> > 
> > I'm asking before I code so as to avoid changing everything later (just call
> > me lazy :-))
> > 
> > david
> > 
> 
> --
> Greg Stein, http://www.lyra.org/
> 
> 

Re: APR_MMAP

[Greg Stein <gs...@lyra.org>]

Doesn't it have to be able to send sub-ranges, in case the client asked
for ranges?

-g

On Thu, 21 Oct 1999, David Reid wrote:
> I'll commit the apr_mmap.h file that I forgot last night (would have done it
> earlier but was grabbed for a Marseille).  A couple of questions that I have
> no real preference over...
> 
> In apr_send_mmap do we want to
> 1) simply have it send the entire file every time it's called
> 2) be able to specify how much of a file should be sent
> 
> I guess it boils down to how we're goign to be using the call in the apache
> code.  The same question applies to the apr_read_mmap.
> 
> I'm asking before I code so as to avoid changing everything later (just call
> me lazy :-))
> 
> david
> 

--
Greg Stein, http://www.lyra.org/