You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@yetus.apache.org by "Allen Wittenauer (Jira)" <ji...@apache.org> on 2020/10/07 03:43:00 UTC

[jira] [Updated] (YETUS-1017) Rework post-processing comparison to de-duplicate code

     [ https://issues.apache.org/jira/browse/YETUS-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen Wittenauer updated YETUS-1017:
------------------------------------
    Release Note: 
<--! markdown -->
Users:

With this change, several plugins that did not generate line comments now do.

Developers:

The `generic_postlog_compare` / `generic_pre_handler` / `generic_post_handler` functions have been deprecated and replaced with `module_postlog_compare` / `module_pre_handler` / `module_post_handler` functions.  A new `root_postlog_compare` has been added that works similarly to `module_postlog_compare` for plug-ins that do not support the MODULE system.  Using `root_postlog_compare` makes writing plug-ins for static linters significantly easier.  See the associated APIs for more information.

> Rework post-processing comparison to de-duplicate code
> ------------------------------------------------------
>
>                 Key: YETUS-1017
>                 URL: https://issues.apache.org/jira/browse/YETUS-1017
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Precommit
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Major
>             Fix For: 0.13.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Originally it was thought that many, many components would be MODULE based.  That's turning out not to be the case.  So a lot of the useful routines labeled 'generic' are stuck behind the MODULE system.  It would be better to specifically rename 'generic' stuff to be 'module' and make new 'generic' routines that assume the root of the tree.  Making this change will greatly improve the ability to quick add new static linters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)