You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/04 06:58:37 UTC
[GitHub] [pulsar] 315157973 opened a new pull request #8198: Remove duplicate updates
315157973 opened a new pull request #8198:
URL: https://github.com/apache/pulsar/pull/8198
### Motivation
Offload has been updated asynchronously in `checkPersistencePolicies()` on line 1888, and there is no need to update repeatedly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #8198: Remove duplicate updates
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8198:
URL: https://github.com/apache/pulsar/pull/8198#issuecomment-703246102
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #8198: Remove duplicate updates
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8198:
URL: https://github.com/apache/pulsar/pull/8198#issuecomment-703227178
@315157973 looks like this is not a dup. it tries to select between ns value and current passedin `Policies`.
@gaoran10 Would you please help double check this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #8198: Remove duplicate updates
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8198:
URL: https://github.com/apache/pulsar/pull/8198#issuecomment-703223599
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8198: Remove duplicate updates
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8198:
URL: https://github.com/apache/pulsar/pull/8198
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #8198: Remove duplicate updates
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8198:
URL: https://github.com/apache/pulsar/pull/8198#issuecomment-703227459
> @315157973 looks like this is not a dup. it tries to select between ns value and current passedin `Policies`.
> @gaoran10 Would you please help double check this change?
`checkPersistencePolicies()` will also trigger getManagedLedgerConfig to set the entire config, including offload
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org