[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #677: Ftr: support get/post/put/patch in rest protocol

[GitBox <gi...@apache.org>]

AlexStocks commented on a change in pull request #677:
URL: https://github.com/apache/dubbo-go/pull/677#discussion_r462229611



##########
File path: protocol/rest/config/reader/rest_config_reader.go
##########
@@ -90,7 +90,7 @@ func initMethodConfigMap(rc *config.RestServiceConfig, consumes string, produces
 	mcm := make(map[string]*config.RestMethodConfig, len(rc.RestMethodConfigs))
 	for _, mc := range rc.RestMethodConfigs {
 		mc.InterfaceName = rc.InterfaceName
-		mc.Path = rc.Path + mc.Path
+		//mc.Path = rc.Path + mc.Path

Review comment:
       delete it if u think it is of no usage.

##########
File path: protocol/rest/rest_protocol.go
##########
@@ -75,9 +75,10 @@ func (rp *RestProtocol) Export(invoker protocol.Invoker) protocol.Exporter {
 	}
 	rp.SetExporterMap(serviceKey, exporter)
 	restServer := rp.getServer(url, restServiceConfig.Server)
-	for _, methodConfig := range restServiceConfig.RestMethodConfigsMap {
+	/*for _, methodConfig := range restServiceConfig.RestMethodConfigsMap {
 		restServer.Deploy(methodConfig, server.GetRouteFunc(invoker, methodConfig))
-	}
+	}*/

Review comment:
       the same as above.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org