[GitHub] [iotdb] qiaojialin commented on a change in pull request #5274: [To rel/0.13] DoubleWrite for 0.13 version

[GitBox <gi...@apache.org>]

qiaojialin commented on a change in pull request #5274:
URL: https://github.com/apache/iotdb/pull/5274#discussion_r831108758



##########
File path: server/src/assembly/resources/conf/iotdb-engine.properties
##########
@@ -926,3 +926,75 @@ timestamp_precision=ms
 ####################
 # Datatype: float
 # group_by_fill_cache_size_in_mb=1.0
+
+####################
+### Double Write Configuration
+####################
+
+####################
+# DOUBLEWRITE GENERAL CONFIG
+####################
+
+# Is DoubleWrite enable
+# Datatype: boolean
+# enable_double_write=false
+# Is DoubleWrite sync
+# Datatype: boolean
+# sync_double_write=true
+
+# Secondary IoTDB config
+# Datatype: String
+# secondary_address=127.0.0.1
+# Datatype: int
+# secondary_port=6668
+# Datatype: String
+# secondary_user=root
+# Datatype: String
+# secondary_password=root
+
+# The transmitting concurrency size of DoubleWrite SessionPool
+# This parameter should better not exceed the sum of concurrent DoubleWriteTask or DoubleWriteConsumer and concurrent DoubleWriteProtector
+# Datatype: int
+# double_write_session_concurrency_size = 8
+
+# The max size per DoubleWriteLog. Default is 1GB
+# Datatype: int
+# double_write_max_log_size = 1073741824
+# The core pool size of DoubleWriteProtector. i.e. The maximum number of running DoubleWriteProtector

Review comment:
       ```suggestion
   
   # The core pool size of DoubleWriteProtector. i.e. The maximum number of running DoubleWriteProtector
   ```

##########
File path: session/src/main/java/org/apache/iotdb/session/Session.java
##########
@@ -2442,6 +2461,24 @@ private TSDropSchemaTemplateReq getTSDropSchemaTemplateReq(String templateName)
     }
   }
 
+  /** Transmit insert record request for double write */
+  public void doubleWriteTransmit(ByteBuffer buffer)

Review comment:
       what's this for?

##########
File path: thrift/src/main/thrift/rpc.thrift
##########
@@ -416,6 +416,12 @@ struct TSDropSchemaTemplateReq {
   2: required string templateName
 }
 
+struct TSExecuteDoubleWriteReq {

Review comment:
       ```suggestion
   struct TSInternalSyncWriteReq {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org