You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/06/24 04:18:24 UTC

[GitHub] [echarts] plainheart commented on a diff in pull request #17252: fix(continuousView): fix multi visualMap bind hoverLink listener.

plainheart commented on code in PR #17252:
URL: https://github.com/apache/echarts/pull/17252#discussion_r905700457


##########
src/component/visualMap/ContinuousView.ts:
##########
@@ -109,6 +109,9 @@ class ContinuousView extends VisualMapView {
 
     private _api: ExtensionAPI;
 
+    private _ownHoverLinkFromSeriesMouseOver = (e: ElementEvent) => this._hoverLinkFromSeriesMouseOver(e);
+
+    private _ownHideIndicator = () => this._hideIndicator();

Review Comment:
   I think we can refer to the [`SliderZoomView`](https://github.com/apache/echarts/blob/master/src/component/dataZoom/SliderZoomView.ts#L135-L141) and use the same strategy.
   
   Note that since some codes use `this.api` rather than `this._api`, you may need to change them to `this._api` after implementing the `init` function. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org