[GitHub] [shenyu] tian-pengfei opened a new issue, #4253: [BUG] should stop executing plugin chain

[GitBox <gi...@apache.org>]

tian-pengfei opened a new issue, #4253:
URL: https://github.com/apache/shenyu/issues/4253

   ### Is there an existing issue for this?
   
   - [X] I have searched the existing issues
   
   ### Current Behavior
   
   By analyzing the code, I found somtimes,We should stop  executing plugin chain,but we don't
   
   ![image](https://user-images.githubusercontent.com/42602026/206825802-86e43e1b-ce83-492c-9993-83631e45d68b.png)
   ![image](https://user-images.githubusercontent.com/42602026/206825881-a2106fd8-2cb1-4802-9c77-a294465058bb.png)
   
   
   ## Check it 
   0. before test 
   ![image](https://user-images.githubusercontent.com/42602026/206827661-d3b2db9d-db17-47bd-8069-a8038785b54d.png)
   
   
   1. add log 
   ![image](https://user-images.githubusercontent.com/42602026/206826235-ac973d75-3a06-452d-96c4-1e0607cc81f3.png)
   
   2. request wrong sign (sign body)
   ![image](https://user-images.githubusercontent.com/42602026/206826319-e4bbaecc-02c9-48f7-a9b7-e2c8c16ab79f.png)
   
   ![image](https://user-images.githubusercontent.com/42602026/206826569-11fc7d78-7a61-4616-a8b5-7c9e88e9e7cb.png)
     
   ![image](https://user-images.githubusercontent.com/42602026/206826559-c8f362e9-cd05-4e5b-af30-12423babd83f.png)
   
   3. request wrong sign (just sign URL)
   ![image](https://user-images.githubusercontent.com/42602026/206826629-c400b47c-95a5-4c61-8059-f6839bb2b538.png)
    
   ![image](https://user-images.githubusercontent.com/42602026/206826673-4a9db7e1-3133-4c11-8323-0a8f1693b765.png)
   
   ![image](https://user-images.githubusercontent.com/42602026/206826611-7a5165c2-c34e-4d0d-b643-12a633cb19b3.png)
   
   ## conclusion
   > Sign plugin should not continute to execute the plugin chain ,when signature is wrong .
   But when verify fail of signature of body ,it doesnt stop executing the plugin.
   When client get result ,the server continute execute plugin for this request 
   That could trigger some unkown error and waste  resources. 
   
   let make a instance about error 
   
   make a wrong URL
   
   ![image](https://user-images.githubusercontent.com/42602026/206827044-ca44581c-f9d2-4dd0-adbc-4eb6566aca39.png)
   
   
   ![image](https://user-images.githubusercontent.com/42602026/206827058-6162d296-a352-413a-a752-e4a0d2a8c915.png)
   
   right result,but some error log in console
   
   ![image](https://user-images.githubusercontent.com/42602026/206827099-676008a3-3b72-409d-964f-d4ca6e46f505.png)
   
   because other plugin after sign-plugin  write response , response was written twice
   
   `CryptorRequestPlugin`  and `CryptorResponsePlugin` have same problem 
   
   
   
   
   
   
   
   
   
   
   ### Expected Behavior
   
   _No response_
   
   ### Steps To Reproduce
   
   _No response_
   
   ### Environment
   
   ```markdown
   ShenYu version(s):
   ```
   
   
   ### Debug logs
   
   _No response_
   
   ### Anything else?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shenyu] yu199195 closed issue #4253: [BUG] should stop executing plugin chain when some errors happen

[GitBox <gi...@apache.org>]

yu199195 closed issue #4253: [BUG] should stop executing plugin chain when some errors happen
URL: https://github.com/apache/shenyu/issues/4253


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org