You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/11/06 22:50:48 UTC
[GitHub] [fineract] vorburger opened a new pull request #1494: Move all SDK client tests into integrationtests (FINERACT-1209)
vorburger opened a new pull request #1494:
URL: https://github.com/apache/fineract/pull/1494
see FINERACT-1209; this now finally runs those tets against localhost instead of https://fineract.dev
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1494: Move all SDK client tests into integrationtests (FINERACT-1209)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1494:
URL: https://github.com/apache/fineract/pull/1494#issuecomment-723345755
Build failed due to:
```
SavingsWorkbookPopulateTest > testSavingsWorkbookPopulate() FAILED
java.lang.AssertionError: 1 expectation failed.
Expected status code <200> but was <500>.
```
I suspect that is probably not related to the changes here, so I'll close and re-open this to see if it "goes away". I've also created FINERACT-1256 to track if this happens more often.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic merged pull request #1494: Move all SDK client tests into integrationtests (FINERACT-1209)
Posted by GitBox <gi...@apache.org>.
vidakovic merged pull request #1494:
URL: https://github.com/apache/fineract/pull/1494
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger closed pull request #1494: Move all SDK client tests into integrationtests (FINERACT-1209)
Posted by GitBox <gi...@apache.org>.
vorburger closed pull request #1494:
URL: https://github.com/apache/fineract/pull/1494
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1494: Move all SDK client tests into integrationtests (FINERACT-1209)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1494:
URL: https://github.com/apache/fineract/pull/1494#issuecomment-723462921
@vidakovic voilà! Phew. Do you want to review and merge this? Other committters welcome.. /Cc @ptuomola
This intentionally has 2 commits (don't squash), as I needed #1498 for FINERACT-1256 as part of this here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org