You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "sarutak (via GitHub)" <gi...@apache.org> on 2023/08/19 20:35:56 UTC

[GitHub] [avro] sarutak opened a new pull request, #2456: AVRO-3837: [Rust] Disallow invalid namespaces for the Rust binding

sarutak opened a new pull request, #2456:
URL: https://github.com/apache/avro/pull/2456

   AVRO-3837
   
   ## What is the purpose of the change
   This PR fixes an issue that `namespace` the Rust binding wrongly accept invalid namespaces in `namespace` fields, while invalid namespaces in `name` fields don't accepted.
   
   For example, the following schema is not accepted as expected.
   ```
   {
     "name": "ns1.invalid-ns.record1",
     "type": "record"
     "fields": []
   }
   ```
   
   But the following schema is wrongly accepted.
   ```
   {
     "name": "record1",
     "namespace": "ns1.invalid-ns",
     "type": "record",
     "fields": []
   }
   ```
   
   ## Verifying this change
   Added new tests and all tests passed with `cargo test --workspace`.
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #2456: AVRO-3837: [Rust] Disallow invalid namespaces for the Rust binding

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2456:
URL: https://github.com/apache/avro/pull/2456#issuecomment-1685886263

   Thank you, @sarutak !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g merged pull request #2456: AVRO-3837: [Rust] Disallow invalid namespaces for the Rust binding

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #2456:
URL: https://github.com/apache/avro/pull/2456


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org