You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/09 14:43:37 UTC

[GitHub] [kafka-site] scott-confluent opened a new pull request #307: [MINOR] fixing docs banner so it appears correctly on older versions

scott-confluent opened a new pull request #307:
URL: https://github.com/apache/kafka-site/pull/307


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka-site] mjsax commented on pull request #307: [MINOR] fixing docs banner so it appears correctly on older versions

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #307:
URL: https://github.com/apache/kafka-site/pull/307#issuecomment-724171811


   We also don't have the banner in `2.5` atm -- can we do a parallel PR to get it back in `2.5` right away?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka-site] bbejeck edited a comment on pull request #307: [MINOR] fixing docs banner so it appears correctly on older versions

Posted by GitBox <gi...@apache.org>.
bbejeck edited a comment on pull request #307:
URL: https://github.com/apache/kafka-site/pull/307#issuecomment-724089999


   \cc @mimaison these changes need to go into 2.6.1 after 2.7 is released


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka-site] mimaison commented on pull request #307: [MINOR] fixing docs banner so it appears correctly on older versions

Posted by GitBox <gi...@apache.org>.
mimaison commented on pull request #307:
URL: https://github.com/apache/kafka-site/pull/307#issuecomment-725353322


   @bbejeck I'm not sure I understand why this is blocking 2.6.1.
   
   Can I port these changes back into kafka/2.6 and start the release process? As far as I can tell, we'll just need to update the website for 2.6.1 after 2.7.0 is released. But we can get started on RCs and votes. And even if a vote passes before 2.7.0 is out, just wait a bit before completing the release.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka-site] bbejeck edited a comment on pull request #307: [MINOR] fixing docs banner so it appears correctly on older versions

Posted by GitBox <gi...@apache.org>.
bbejeck edited a comment on pull request #307:
URL: https://github.com/apache/kafka-site/pull/307#issuecomment-724089999


   ~\cc @mimaison these changes need to go into 2.6.1 after 2.7 is released~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka-site] scott-confluent commented on pull request #307: [MINOR] fixing docs banner so it appears correctly on older versions

Posted by GitBox <gi...@apache.org>.
scott-confluent commented on pull request #307:
URL: https://github.com/apache/kafka-site/pull/307#issuecomment-724102500


   ## NOTE: this should NOT be merged until 2.7 is officially released


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka-site] bbejeck merged pull request #307: [MINOR] fixing docs banner so it appears correctly on older versions

Posted by GitBox <gi...@apache.org>.
bbejeck merged pull request #307:
URL: https://github.com/apache/kafka-site/pull/307


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka-site] bbejeck commented on pull request #307: [MINOR] fixing docs banner so it appears correctly on older versions

Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #307:
URL: https://github.com/apache/kafka-site/pull/307#issuecomment-725453823


   @mimaison this shouldn't block 2.6.1; my apologies; I misunderstood what needed to happen.
   
   After 2.7 get released, I'll merge this PR, but for now, there's nothing you need to do as 2.6.x is the current version.
   \cc @scott-confluent 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka-site] bbejeck commented on pull request #307: [MINOR] fixing docs banner so it appears correctly on older versions

Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #307:
URL: https://github.com/apache/kafka-site/pull/307#issuecomment-724089999


   \cc @mimaison these changes need to go into 2.6.1 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org