You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/26 18:09:51 UTC

[GitHub] [pulsar] gaoran10 opened a new pull request #7909: Support use `BitSet` generate the `BatchMessageAcker`

gaoran10 opened a new pull request #7909:
URL: https://github.com/apache/pulsar/pull/7909


   ### Motivation
   
   Currently, we have to know the batchSize to generate `BatchMessageAcker`. If we could get the batch index ack bitSet from Broker we could generate the `BatchMessageAcker` by the bitSet, this is useful for consuming transaction messages.
   
   ### Modifications
   
   Add a new static method to generate the `BatchMessageAcker` by `BitSet`.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change added tests.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai merged pull request #7909: Support use `BitSet` generate the `BatchMessageAcker`

Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #7909:
URL: https://github.com/apache/pulsar/pull/7909


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] gaoran10 commented on pull request #7909: Support use `BitSet` generate the `BatchMessageAcker`

Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #7909:
URL: https://github.com/apache/pulsar/pull/7909#issuecomment-683929273


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] gaoran10 commented on pull request #7909: Support use `BitSet` generate the `BatchMessageAcker`

Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #7909:
URL: https://github.com/apache/pulsar/pull/7909#issuecomment-683855973


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #7909: Support use `BitSet` generate the `BatchMessageAcker`

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7909:
URL: https://github.com/apache/pulsar/pull/7909#issuecomment-683425715


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org