[GitHub] [airflow] potiuk commented on a change in pull request #13562: Optimize wait for prod images to be run after ci images

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #13562:
URL: https://github.com/apache/airflow/pull/13562#discussion_r553895149



##########
File path: .github/workflows/ci.yml
##########
@@ -834,7 +834,7 @@ jobs:
     timeout-minutes: 120
     name: "Wait for PROD images"
     runs-on: ubuntu-20.04
-    needs: [build-info]
+    needs: [build-info, ci-images]

Review comment:
       I could add it, but I think this is a 'target' optimization. Even if  we switch to self-hosted runners, we want to keep  it in.
   
   Currently our dependency model looks like:
   
   1) Workflow run  builds CI image -> once done CI Iimage waiting finishes and CI tests run
   
   2) in Worklflow Run PROD images are build using the CI images from step 1 (this is needed to build provider packages because prod images are build from packages now). 
   
   Step 2) depends on 1), so there will never be the case that PROD images will be available before CI images.. So waiting for PROD images in parallel to CI images simply makes no sense.
   
   
   
   
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org