You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "zhangjun0x01 (via GitHub)" <gi...@apache.org> on 2023/07/04 15:32:45 UTC

[GitHub] [incubator-paimon] zhangjun0x01 opened a new pull request, #1498: [core]the creation_time of FilesTable should be local date time

zhangjun0x01 opened a new pull request, #1498:
URL: https://github.com/apache/incubator-paimon/pull/1498

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   the creation_time of FilesTable should be local date time ,  the snapshots create time is correct.
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] JingsongLi merged pull request #1498: [core]the creation_time of FilesTable should be local date time

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #1498:
URL: https://github.com/apache/incubator-paimon/pull/1498


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] zhangjun0x01 commented on pull request #1498: [core]the creation_time of FilesTable should be local date time

Posted by "zhangjun0x01 (via GitHub)" <gi...@apache.org>.
zhangjun0x01 commented on PR #1498:
URL: https://github.com/apache/incubator-paimon/pull/1498#issuecomment-1623208126

   > The correct fixing should in `DataFileMeta`.
   > 
   > ```
   > Timestamp.fromEpochMillis(System.currentTimeMillis())
   > ```
   > 
   > Should be
   > 
   > ```
   > Timestamp.fromLocalDateTime(LocalDateTime.now())
   > ```
   
   I updated it follow your suggestion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org