You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/04/20 12:42:39 UTC

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1306: MINIFICPP-1802 Do not make EC2 HTTP calls when AWS extension is not used

lordgamez commented on code in PR #1306:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1306#discussion_r854087624


##########
libminifi/test/aws-tests/MockS3RequestSender.h:
##########
@@ -290,5 +290,5 @@ class MockS3RequestSender : public minifi::aws::s3::S3RequestSender {
   bool return_empty_result_ = false;
   bool is_listing_truncated_ = false;
   Aws::Auth::AWSCredentials credentials_;
-  Aws::Client::ClientConfiguration client_config_;
+  Aws::Client::ClientConfiguration* client_config_;

Review Comment:
   Good point, updated in 1f4cadb5a3ddac9459b2d1a3a7520f21bb36f103



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org