[GitHub] [guacamole-server] myjimmy commented on a change in pull request #317: GUACAMOLE-1186: Maintain the clipboard content of the remote server.

[GitBox <gi...@apache.org>]

myjimmy commented on a change in pull request #317:
URL: https://github.com/apache/guacamole-server/pull/317#discussion_r547099769



##########
File path: src/protocols/rdp/channels/cliprdr.c
##########
@@ -283,7 +283,8 @@ static UINT guac_rdp_cliprdr_format_list(CliprdrClientContext* cliprdr,
     if (guac_rdp_cliprdr_format_supported(format_list, CF_TEXT))
         return guac_rdp_cliprdr_send_format_data_request(cliprdr, CF_TEXT);
 
-    /* Ignore any unsupported data */
+    /* Suppose that any unsupported data is raw data (in this case, CF_RAW) */
+    guac_rdp_cliprdr_send_format_data_request(cliprdr, CF_RAW);

Review comment:
       guac_rdp_cliprdr_format_list() function is called when copying any data in the remote server.
   In this function, we need to tell the remote server whether the remote client supports the clipboard format of the remote clipboard.
   Users can copy any kind of data including text in the remote server.
   Because I thought that CF_RAW indicates any kind of clipboard data, I selected the clipboard format as CF_RAW.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org