[GitHub] [arrow-rs] viirya commented on a diff in pull request #4313: Use `page_size` consistently, deprecate `pagesize` in parquet WriterProperties

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #4313:
URL: https://github.com/apache/arrow-rs/pull/4313#discussion_r1210875373


##########
parquet/src/file/properties.rs:
##########
@@ -351,16 +370,32 @@ impl WriterPropertiesBuilder {
     ///
     /// Note: this is a best effort limit based on value of
     /// [`set_write_batch_size`](Self::set_write_batch_size).
+    #[deprecated(since = "41.0.0", note = "Use set_dictionary_page_size_limit")]

Review Comment:
   ```suggestion
       #[deprecated(since = "41.0.0", note = "Use set_data_page_size_limit")]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org