You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/09/25 07:19:16 UTC

[GitHub] [logging-log4cxx] ams-tschoening commented on pull request #42: fix build without wchar

ams-tschoening commented on pull request #42:
URL: https://github.com/apache/logging-log4cxx/pull/42#issuecomment-698767348


   How does keeping `encode` as a no-op make sense here? Either it's called, then making it a no-op breaks on runtime only or it's not, then itself should be `#ifdef`ed in my opinion, not its implementation only.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org