You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martijn Dashorst (JIRA)" <ji...@apache.org> on 2015/08/06 14:04:05 UTC
[jira] [Commented] (WICKET-5961) Wicket1.5 TreeTable can't find
markup
[ https://issues.apache.org/jira/browse/WICKET-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659899#comment-14659899 ]
Martijn Dashorst commented on WICKET-5961:
------------------------------------------
I've bisected Wicket and this issue, and the regression was introduced by removing 'old wicket 1.4->1.5' migration code from DefaultMarkupSourcingStrategy in commit https://github.com/apache/wicket/commit/f89b15618243075f8a8e90cb826550af525dabb7, that actually had one side effect on line 123 of the diff:
{code}
// The LoopItems markup is equal to the Loops markup
markup = container.getMarkup();
{code}
Reintroducing this old behaviour into DefaultMarkupSourcingStrategy solves the problem from the TreeTableItem, but lets two test cases in Wicket 7 fail:
1. MarkupFragmentTest.panel
2. MarkupFragmentTest.panelWithAutoComponent
Both with the following failure:
{code}
java.lang.AssertionError: expected null, but was:<file:/Users/dashorst/Workspaces/wicket7/wicket/wicket-core/target/test-classes/org/apache/wicket/markupFragments/MyPage.html
<!--
====================================================================
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<html xmlns:wicket>
<head></head><body>
<span wicket:id="label">text</span>
<span wicket:id="container">text</span>
</body>
</html>
>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotNull(Assert.java:755)
at org.junit.Assert.assertNull(Assert.java:737)
at org.junit.Assert.assertNull(Assert.java:747)
at org.apache.wicket.markupFragments.MarkupFragmentTest.panel(MarkupFragmentTest.java:70)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)
{code}
This assertion fails:
{code}
// The Page is missing the tag to "call" the panel
assertNull(panel.getMarkup());
{code}
> Wicket1.5 TreeTable can't find markup
> -------------------------------------
>
> Key: WICKET-5961
> URL: https://issues.apache.org/jira/browse/WICKET-5961
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 7.0.0
> Reporter: Martijn Dashorst
>
> The recently moved TreeTable can't find its markup (for a TreeTableItem):
> {code}
> org.apache.wicket.markup.MarkupNotFoundException: Markup not found for Component: [TreeTableItem [Component id = 0]]
> at org.apache.wicket.Component.internalRender(Component.java:2347)
> at org.apache.wicket.Component.render(Component.java:2307)
> at org.apache.wicket.extensions.markup.html.tree.table.SideColumnsView.onRender(SideColumnsView.java:103)
> at org.apache.wicket.Component.internalRender(Component.java:2379)
> at org.apache.wicket.Component.render(Component.java:2307)
> at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1407)
> at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1604)
> at org.apache.wicket.MarkupContainer.renderComponentTagBody(MarkupContainer.java:1579)
> at org.apache.wicket.MarkupContainer.renderAssociatedMarkup(MarkupContainer.java:691)
> at org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderAssociatedMarkup(AssociatedMarkupSourcingStrategy.java:77)
> at org.apache.wicket.markup.html.panel.PanelMarkupSourcingStrategy.onComponentTagBody(PanelMarkupSourcingStrategy.java:112)
> at org.apache.wicket.Component.internalRenderComponent(Component.java:2564)
> at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1543)
> at org.apache.wicket.Component.internalRender(Component.java:2379)
> at org.apache.wicket.Component.render(Component.java:2307)
> at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1407)
> at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1604)
> at org.apache.wicket.Page.onRender(Page.java:879)
> at org.apache.wicket.markup.html.WebPage.onRender(WebPage.java:141)
> at org.apache.wicket.Component.internalRender(Component.java:2379)
> at org.apache.wicket.Component.render(Component.java:2307)
> at org.apache.wicket.Page.renderPage(Page.java:1018)
> at org.apache.wicket.request.handler.render.WebPageRenderer.renderPage(WebPageRenderer.java:124)
> at org.apache.wicket.request.handler.render.WebPageRenderer.respond(WebPageRenderer.java:236)
> at org.apache.wicket.util.tester.BaseWicketTester$LastPageRecordingPageRendererProvider$1.respond(BaseWicketTester.java:2745)
> at org.apache.wicket.core.request.handler.RenderPageRequestHandler.respond(RenderPageRequestHandler.java:175)
> at org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:865)
> at org.apache.wicket.request.RequestHandlerStack.execute(RequestHandlerStack.java:64)
> at org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:265)
> at org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:222)
> at org.apache.wicket.request.cycle.RequestCycle.processRequestAndDetach(RequestCycle.java:293)
> at org.apache.wicket.util.tester.BaseWicketTester.processRequest(BaseWicketTester.java:718)
> at org.apache.wicket.util.tester.BaseWicketTester.processRequest(BaseWicketTester.java:657)
> at org.apache.wicket.util.tester.BaseWicketTester.processRequest(BaseWicketTester.java:629)
> at org.apache.wicket.util.tester.BaseWicketTester.startPage(BaseWicketTester.java:1262)
> at org.apache.wicket.util.tester.BaseWicketTester.startPage(BaseWicketTester.java:1235)
> at org.apache.wicket.extensions.markup.html.tree.HomePageTest.homepageRenders(HomePageTest.java:10)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
> at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)
> {code}
> While the TreeTable (and other components from wicket15 tree) were moved as they are considered unsupported, the current implementation of Wicket 7 seems like a regression.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)