You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ssulav (via GitHub)" <gi...@apache.org> on 2026/02/25 10:24:23 UTC
[PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
ssulav opened a new pull request, #9826:
URL: https://github.com/apache/ozone/pull/9826
## What changes were proposed in this pull request?
In the datanode usgae info, update Remaining Allocatable to also consider Free Space To Spare.
Right now, it is showing the capacity only in the allocatable which is not totally true, as min free space to spare should be excluded.
## What is the link to the Apache JIRA
[HDDS-14718](https://issues.apache.org/jira/browse/HDDS-14718)
## How was this patch tested?
It is to be tested manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #9826: HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare
URL: https://github.com/apache/ozone/pull/9826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9826:
URL: https://github.com/apache/ozone/pull/9826#issuecomment-4149077837
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "ssulav (via GitHub)" <gi...@apache.org>.
ssulav commented on code in PR #9826:
URL: https://github.com/apache/ozone/pull/9826#discussion_r2869546720
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/UsageInfoSubcommand.java:
##########
@@ -155,8 +155,8 @@ private void printInfo(DatanodeUsage info) {
System.out.printf("%-24s: %s (%s) %n", "Container Pre-allocated",
info.getCommitted() + " B", StringUtils.byteDesc(info.getCommitted()));
System.out.printf("%-24s: %s (%s) %n", "Remaining Allocatable",
- (info.getOzoneAvailable() - info.getCommitted()) + " B",
- StringUtils.byteDesc((info.getOzoneAvailable() - info.getCommitted())));
+ info.getRemainingAllocatable() + " B",
+ StringUtils.byteDesc(info.getRemainingAllocatable()));
Review Comment:
Added. Please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9826:
URL: https://github.com/apache/ozone/pull/9826#issuecomment-4930778744
Thank you for your contribution. This PR is being closed due to inactivity. Please contact a maintainer if you would like to reopen it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "siddhantsangwan (via GitHub)" <gi...@apache.org>.
siddhantsangwan commented on code in PR #9826:
URL: https://github.com/apache/ozone/pull/9826#discussion_r2870551659
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/UsageInfoSubcommand.java:
##########
@@ -155,8 +155,8 @@ private void printInfo(DatanodeUsage info) {
System.out.printf("%-24s: %s (%s) %n", "Container Pre-allocated",
info.getCommitted() + " B", StringUtils.byteDesc(info.getCommitted()));
System.out.printf("%-24s: %s (%s) %n", "Remaining Allocatable",
- (info.getOzoneAvailable() - info.getCommitted()) + " B",
- StringUtils.byteDesc((info.getOzoneAvailable() - info.getCommitted())));
+ info.getRemainingAllocatable() + " B",
+ StringUtils.byteDesc(info.getRemainingAllocatable()));
Review Comment:
Should we rename Container Pre Allocated to Committed? Or else use Container Pre allocated in the help string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "siddhantsangwan (via GitHub)" <gi...@apache.org>.
siddhantsangwan commented on code in PR #9826:
URL: https://github.com/apache/ozone/pull/9826#discussion_r2870627425
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/UsageInfoSubcommand.java:
##########
@@ -155,8 +155,8 @@ private void printInfo(DatanodeUsage info) {
System.out.printf("%-24s: %s (%s) %n", "Container Pre-allocated",
info.getCommitted() + " B", StringUtils.byteDesc(info.getCommitted()));
System.out.printf("%-24s: %s (%s) %n", "Remaining Allocatable",
- (info.getOzoneAvailable() - info.getCommitted()) + " B",
- StringUtils.byteDesc((info.getOzoneAvailable() - info.getCommitted())));
+ info.getRemainingAllocatable() + " B",
+ StringUtils.byteDesc(info.getRemainingAllocatable()));
Review Comment:
Best to check what recon and other places are using and use the same name consistently everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9826:
URL: https://github.com/apache/ozone/pull/9826#issuecomment-4375573326
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "ssulav (via GitHub)" <gi...@apache.org>.
ssulav commented on PR #9826:
URL: https://github.com/apache/ozone/pull/9826#issuecomment-4237194602
@adoroszlai / @siddhantsangwan - Your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #9826: HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare
URL: https://github.com/apache/ozone/pull/9826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "ssulav (via GitHub)" <gi...@apache.org>.
ssulav commented on PR #9826:
URL: https://github.com/apache/ozone/pull/9826#issuecomment-4237190851
The formula looks lengthy and less readable
`Remaining Allocatable : 186903769088 B (Ozone Available - Container Pre-allocated - Free Space To Spare)`
```
UUID : 2bf7fec8-5404-4557-a762-ea4cfb876dcd
IP Address : 172.25.0.103
Hostname : ozonesecure-ha-datanode2-1.ozonesecure-ha_ozone_net
Filesystem Capacity : 210240512000 B (195.80 GB)
Filesystem Used : 23231885312 B (21.64 GB)
Filesystem Used % : 11.05% (Filesystem Used/Filesystem Capacity)
Filesystem Available : 187008626688 B (174.17 GB)
Filesystem Available % : 88.95% (Filesystem Available/Filesystem Capacity)
Ozone Capacity : 210219487950 B (195.78 GB)
Ozone Used : 4382720 B (4.18 MB)
Ozone Used % : 0.00% (Ozone Used/Ozone Capacity)
Ozone Available : 187008626688 B (174.17 GB)
Ozone Available % : 88.96% (Ozone Available/Ozone capacity)
Pipeline(s) : 3
Container(s) : 0
Container Pre-allocated : 0 B (0 B)
Remaining Allocatable : 186903769088 B (Ozone Available - Container Pre-allocated - Free Space To Spare)
Free Space To Spare : 104857600 B (100 MB)
Reserved : 21024050 B (20.05 MB)
```
Shall I put abbreviations at each field so that I can use them in representing formula.
E.g.
Filesystem Capacity [FC]
Filesystem Used [FU]
Filesystem Used % : ... [FU/FC]
or A, B, C
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9826:
URL: https://github.com/apache/ozone/pull/9826#issuecomment-4585255931
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "ssulav (via GitHub)" <gi...@apache.org>.
ssulav commented on code in PR #9826:
URL: https://github.com/apache/ozone/pull/9826#discussion_r2872828127
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/UsageInfoSubcommand.java:
##########
@@ -155,8 +155,8 @@ private void printInfo(DatanodeUsage info) {
System.out.printf("%-24s: %s (%s) %n", "Container Pre-allocated",
info.getCommitted() + " B", StringUtils.byteDesc(info.getCommitted()));
System.out.printf("%-24s: %s (%s) %n", "Remaining Allocatable",
- (info.getOzoneAvailable() - info.getCommitted()) + " B",
- StringUtils.byteDesc((info.getOzoneAvailable() - info.getCommitted())));
+ info.getRemainingAllocatable() + " B",
+ StringUtils.byteDesc(info.getRemainingAllocatable()));
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "siddhantsangwan (via GitHub)" <gi...@apache.org>.
siddhantsangwan commented on PR #9826:
URL: https://github.com/apache/ozone/pull/9826#issuecomment-3988656301
@ssulav There's a checkstyle failure, you'll need to split the line to multiple lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9826:
URL: https://github.com/apache/ozone/pull/9826#issuecomment-4187965589
Thank you for your contribution. This PR is being closed due to inactivity. Please contact a maintainer if you would like to reopen it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "siddhantsangwan (via GitHub)" <gi...@apache.org>.
siddhantsangwan commented on PR #9826:
URL: https://github.com/apache/ozone/pull/9826#issuecomment-4010152609
Created https://issues.apache.org/jira/browse/HDDS-14774 for the CI failure. Rerunning it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #9826:
URL: https://github.com/apache/ozone/pull/9826#issuecomment-4015918358
> ## How was this patch tested?
> It is to be tested manually.
Please include steps and sample output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org