[jira] [Assigned] (YARN-9355) RMContainerRequestor#makeRemoteRequest has confusing log message

["Ashutosh Gupta (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YARN-9355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Gupta reassigned YARN-9355:
------------------------------------

    Assignee: Ashutosh Gupta  (was: Umesh Mittal)

> RMContainerRequestor#makeRemoteRequest has confusing log message
> ----------------------------------------------------------------
>
>                 Key: YARN-9355
>                 URL: https://issues.apache.org/jira/browse/YARN-9355
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Ashutosh Gupta
>            Priority: Trivial
>              Labels: newbie, newbie++
>         Attachments: YARN-9355.001.patch, YARN-9355.002.patch
>
>
> org.apache.hadoop.mapreduce.v2.app.rm.RMContainerRequestor#makeRemoteRequest has this log: 
> {code:java}
> if (ask.size() > 0 || release.size() > 0) {
>       LOG.info("getResources() for " + applicationId + ":" + " ask="
>           + ask.size() + " release= " + release.size() + " newContainers="
>           + allocateResponse.getAllocatedContainers().size()
>           + " finishedContainers=" + numCompletedContainers
>           + " resourcelimit=" + availableResources + " knownNMs="
>           + clusterNmCount);
>     }
> {code}
> The reason why "getResources()" is printed because org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator#getResources invokes makeRemoteRequest. This is not too informative and error-prone as name of getResources could change over time and the log will be outdated. Moreover, it's not a good idea to print a method name from a method below the current one in the stack.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org