You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Benjamin Zhitomirsky <be...@gmail.com> on 2014/04/02 17:07:08 UTC

Review Request 19923: HIVE-6374: Hive job submitted with non-default name node (fs.default.name) doesn't process locations properly

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19923/
-----------------------------------------------------------

Review request for hive.


Repository: hive-git


Description
-------

Create table/index/database and add partition DDL doesn't work properly if all following conditions are true:
?Metastore service is used
?fs.default.name is specified and it differs from the default one
?Location is not specified or specified as a not fully qualified URI

The root cause of this behavior is that Hive client doesn't pass configuration context to the metastore services which tries to resolve the paths. The fix is it too resolve the path in the Hive client if fs.default.name is specified and it differs from the default one (it is must easier then start passing the context, which would be a major change).


Diffs
-----

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestDDLWithRemoteMetastoreSecondNamenode.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 699a30d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 9a74fa5 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ed03fba 

Diff: https://reviews.apache.org/r/19923/diff/


Testing
-------

Tested in deployed Hadoop cluster. New class with two tests added.


Thanks,

Benjamin Zhitomirsky


Re: Review Request 19923: HIVE-6374: Hive job submitted with non-default name node (fs.default.name) doesn't process locations properly

Posted by Benjamin Zhitomirsky <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19923/
-----------------------------------------------------------

(Updated April 30, 2014, 11:14 a.m.)


Review request for hive.


Changes
-------

Updated after sync with latest trunk
Fixed bug wrong casing of table/index/db paths


Repository: hive-git


Description
-------

Create table/index/database and add partition DDL doesn't work properly if all following conditions are true:
-Metastore service is used
-fs.default.name is specified and it differs from the default one
-Location is not specified or specified as a not fully qualified URI

The root cause of this behavior is that Hive client doesn't pass configuration context to the metastore services which tries to resolve the paths. The fix is it too resolve the path in the Hive client if fs.default.name is specified and it differs from the default one (it is must easier then start passing the context, which would be a major change).


Diffs (updated)
-----

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestDDLWithRemoteMetastoreSecondNamenode.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java ca51e71 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 3ea2163 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java d8ad873 

Diff: https://reviews.apache.org/r/19923/diff/


Testing
-------

Tested in deployed Hadoop cluster. New class with two tests added.


Thanks,

Benjamin Zhitomirsky


Re: Review Request 19923: HIVE-6374: Hive job submitted with non-default name node (fs.default.name) doesn't process locations properly

Posted by Benjamin Zhitomirsky <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19923/
-----------------------------------------------------------

(Updated April 3, 2014, 8:05 p.m.)


Review request for hive.


Changes
-------

Tests updated, were failing on Windows


Repository: hive-git


Description (updated)
-------

Create table/index/database and add partition DDL doesn't work properly if all following conditions are true:
-Metastore service is used
-fs.default.name is specified and it differs from the default one
-Location is not specified or specified as a not fully qualified URI

The root cause of this behavior is that Hive client doesn't pass configuration context to the metastore services which tries to resolve the paths. The fix is it too resolve the path in the Hive client if fs.default.name is specified and it differs from the default one (it is must easier then start passing the context, which would be a major change).


Diffs (updated)
-----

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestDDLWithRemoteMetastoreSecondNamenode.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 699a30d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 9a74fa5 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ed03fba 

Diff: https://reviews.apache.org/r/19923/diff/


Testing
-------

Tested in deployed Hadoop cluster. New class with two tests added.


Thanks,

Benjamin Zhitomirsky