You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/11/17 14:03:57 UTC
[GitHub] [incubator-streampark] wolfboys opened a new pull request, #2046: [Bug] alarm test bug fixed
wolfboys opened a new pull request, #2046:
URL: https://github.com/apache/incubator-streampark/pull/2046
[Bug] alarm test bug fixed
## What changes were proposed in this pull request
Issue Number: close #xxx <!-- REMOVE this line if no issue to close -->
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verifying this change
<!--*(Please pick either of the following options)*-->
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added integration tests for end-to-end.*
- *Added *Test to verify the change.*
- *Manually verified the change by testing locally.* -->
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] 1996fanrui commented on pull request #2046: [Bug] alarm test bug fixed
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #2046:
URL: https://github.com/apache/incubator-streampark/pull/2046#issuecomment-1318722137
> > Could you add som background? I don't know why need to change these code.
>
> you can see: `AlertServiceImpl` line 81 for more detail.
After I see, I think current code can fix bug. However, I don't think it's a good solution.
The code is very unclear. Except for the developer himself, no one else may know that the name is used to find the service. That why you write a bug in #2023
Clear code can reduce a lot of bugs, don't write a lot of implicit constraints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #2046: [Bug] alarm test bug fixed
Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #2046:
URL: https://github.com/apache/incubator-streampark/pull/2046#issuecomment-1318784998
cc @1996fanrui PTAL again, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] 1996fanrui commented on pull request #2046: [Bug] alarm test bug fixed
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #2046:
URL: https://github.com/apache/incubator-streampark/pull/2046#issuecomment-1318729336
I've seen too many bugs caused by implicit constraints in StreamPark. Every logic should have some code to implement, instead of implementing features by naming.
Long-term tolerance of low-quality code will make the project very difficult to maintain in the future, and very prone to bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] 1996fanrui commented on pull request #2046: [Bug] alarm test bug fixed
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #2046:
URL: https://github.com/apache/incubator-streampark/pull/2046#issuecomment-1318692552
Could you add som background? I don't know why need to change these code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] 1996fanrui merged pull request #2046: [Bug] alarm test bug fixed
Posted by GitBox <gi...@apache.org>.
1996fanrui merged PR #2046:
URL: https://github.com/apache/incubator-streampark/pull/2046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #2046: [Bug] alarm test bug fixed
Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #2046:
URL: https://github.com/apache/incubator-streampark/pull/2046#issuecomment-1318696443
> Could you add som background? I don't know why need to change these code.
you can see: `AlertServiceImpl` line 81 for more detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org