You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "AyoubOm (via GitHub)" <gi...@apache.org> on 2023/11/04 16:01:59 UTC
[PR] MINOR: add clarification about log compaction [kafka]
AyoubOm opened a new pull request, #14701:
URL: https://github.com/apache/kafka/pull/14701
*Add a note about log compaction behavior. The term "old data" used may be misunderstood as old data with respect of time, instead of old data associated with a given key*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: add clarification about log compaction [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14701:
URL: https://github.com/apache/kafka/pull/14701#issuecomment-2570032514
This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: add clarification about log compaction [kafka]
Posted by "AyoubOm (via GitHub)" <gi...@apache.org>.
AyoubOm commented on code in PR #14701:
URL: https://github.com/apache/kafka/pull/14701#discussion_r1385285680
##########
docs/streams/architecture.html:
##########
@@ -148,7 +148,8 @@ <h3 class="anchor-heading"><a id="streams_architecture_recovery" class="anchor-l
<p>
In addition, Kafka Streams makes sure that the local state stores are robust to failures, too. For each state store, it maintains a replicated changelog Kafka topic in which it tracks any state updates.
These changelog topics are partitioned as well so that each local state store instance, and hence the task accessing the store, has its own dedicated changelog topic partition.
- <a href="/{{version}}/documentation/#compaction">Log compaction</a> is enabled on the changelog topics so that old data can be purged safely to prevent the topics from growing indefinitely.
+ <a href="/{{version}}/documentation/#compaction">Log compaction</a> is enabled on the changelog topics so that old data can be purged safely to prevent the topics from growing indefinitely
+ (Keep in mind that this behavior is different from a "delete" clean-up policy in that the most recent event associated with a key is always preserved).
Review Comment:
@ex172000 actually the explanation that comes after is for _Log compaction_ behavior (the former in the sentence) and not _delete_
I will remove the parentheses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: add clarification about log compaction [kafka]
Posted by "ex172000 (via GitHub)" <gi...@apache.org>.
ex172000 commented on code in PR #14701:
URL: https://github.com/apache/kafka/pull/14701#discussion_r1384984849
##########
docs/streams/architecture.html:
##########
@@ -148,7 +148,8 @@ <h3 class="anchor-heading"><a id="streams_architecture_recovery" class="anchor-l
<p>
In addition, Kafka Streams makes sure that the local state stores are robust to failures, too. For each state store, it maintains a replicated changelog Kafka topic in which it tracks any state updates.
These changelog topics are partitioned as well so that each local state store instance, and hence the task accessing the store, has its own dedicated changelog topic partition.
- <a href="/{{version}}/documentation/#compaction">Log compaction</a> is enabled on the changelog topics so that old data can be purged safely to prevent the topics from growing indefinitely.
+ <a href="/{{version}}/documentation/#compaction">Log compaction</a> is enabled on the changelog topics so that old data can be purged safely to prevent the topics from growing indefinitely
+ (Keep in mind that this behavior is different from a "delete" clean-up policy in that the most recent event associated with a key is always preserved).
Review Comment:
`in which the`? Also maybe remove the parentheses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: add clarification about log compaction [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14701:
URL: https://github.com/apache/kafka/pull/14701#issuecomment-1928723236
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: add clarification about log compaction [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #14701: MINOR: add clarification about log compaction
URL: https://github.com/apache/kafka/pull/14701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org